[fix] Install latest published release from GitHub #407 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Good work @youhaveme9!
I have tested this and it works as expected. I have left some minor suggestions below. Once, those changes are made we can go ahead and merge this PR.
deploy/auto-install.sh
Outdated
| @@ -54,10 +54,18 @@ error_msg_with_continue() { | |||
|
|
|||
| apt_dependenices_setup() { | |||
| start_step "Setting up dependencies..." | |||
| apt --yes install python3 python3-pip git python3-dev gawk libffi-dev libssl-dev gcc make &>>$LOG_FILE | |||
| apt --yes install python3 python3-pip git python3-dev gawk libffi-dev libssl-dev gcc make curl &>>$LOG_FILE | |||
There was a problem hiding this comment.
Let's also include jq, so we don't into similar errors like curl.
deploy/auto-install.sh
Outdated
| echo -ne ${GRN}"OpenWISP Version (leave blank for latest): "${NON} | ||
| read openwisp_version | ||
| if [[ -z "$openwisp_version" ]]; then | ||
| openwisp_version=$(curl -L --silent https://api.github.com/repos/openwisp/docker-openwisp/releases/latest | jq .tag_name | tr -d '"') |
There was a problem hiding this comment.
Suggested change
| openwisp_version=$(curl -L --silent https://api.github.com/repos/openwisp/docker-openwisp/releases/latest | jq .tag_name | tr -d '"') | |
| openwisp_version=$(curl -L --silent https://api.github.com/repos/openwisp/docker-openwisp/releases/latest | jq -r .tag_name) |
|
Hey @pandafy |
pandafy
changed the title
pandafy
changed the title
nemesifier
reviewed
Dec 17, 2024
There was a problem hiding this comment.
THanks @youhaveme9 @pandafy, I merged the latest master and started the build.
nemesifier
approved these changes
Dec 18, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #407.
Description of Changes
Updated auto-install script to get the latest release from GitHub by default instead of installing the release with "latest" tag.