Updated version of FastAPI (migrate to Pydantic2 and others) #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cover FastAPI security updates (new versions of FastAPI use Pydantic 2) and future-proofing, need to update the oidc controller in VCAuthn to use Pydantic 2. Other minor FastAPI update tweaks required as well.
Some relevant Pydantic2 changes
Optional logic changed in Pydantic 2
https://docs.pydantic.dev/latest/migration/#required-optional-and-nullable-fields
Using ConfigDict instead of class based config
https://docs.pydantic.dev/latest/migration/#changes-to-config
Get validators is gone
https://docs.pydantic.dev/latest/migration/#defining-custom-types
Additionally needed minor tweak to the way the socket.io endpoint sets up as the mount to
/wsstopped working in newer FastAPI (or python-socket) so defining the whole path in the socket app works now (explicitly setsocketio_path).