Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #415

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

esune
Copy link
Member

@esune esune commented Feb 12, 2024

Resolves #408 , #409

Added basic documentation for mapper configuration, removed references to email-verification - now there is a dependency on the BC Wallet Showcase to obtain a demo credential.

@esune esune requested a review from loneil February 12, 2024 20:43
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — verified that the identifiers match

@loneil
Copy link
Contributor

loneil commented Feb 12, 2024

Not sure why but tore everything down, got this branch and built fresh, and in the demo app to test I see
{"detail":"The requested verifier configuration wasn't found"}

Api is still getting a verified-email request from somewhere but I can't find it yet...

Never mind this. My local browser had a cached version of the vue app, incognito fixed it.

Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started this up fresh locally, added the showcase cred config with curl, got a showcase cred on my phone through the link, and ran through the Vue demo and it works for me. 👍

README.md Show resolved Hide resolved
@esune esune merged commit bafd3cf into openwallet-foundation:main Feb 12, 2024
5 checks passed
@esune esune deleted the chore/update-docs branch February 12, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mapper configuration to configuration guide
3 participants