init vp_format support #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Tuerk <[email protected]>
Signed-off-by: Johannes Tuerk <[email protected]>
Signed-off-by: Johannes Tuerk <[email protected]>
Signed-off-by: Johannes Tuerk <[email protected]>
Signed-off-by: Johannes Tuerk <[email protected]>
Signed-off-by: Johannes Tuerk <[email protected]>
kenkosmowski
requested changes
Jan 16, 2025
| /// <returns>An array of credential candidates, each containing a list of credentials that match the input descriptors.</returns> | ||
| Task<PresentationCandidates[]> FindCredentialCandidates(IEnumerable<InputDescriptor> inputDescriptors); | ||
| Task<PresentationCandidates[]> FindCredentialCandidates(IEnumerable<InputDescriptor> inputDescriptors, Formats? supportedFormatSigningAlgorithms = null); |
There was a problem hiding this comment.
Option instead of Formats?
| @@ -40,23 +42,18 @@ public Task<PresentationSubmission> CreatePresentationSubmission( | |||
| } | |||
|
|
|||
| /// <inheritdoc /> | |||
| public virtual async Task<PresentationCandidates[]> FindCredentialCandidates(IEnumerable<InputDescriptor> inputDescriptors) | |||
| public virtual async Task<PresentationCandidates[]> FindCredentialCandidates(IEnumerable<InputDescriptor> inputDescriptors, Formats? supportedFormatSigningAlgorithms) | |||
There was a problem hiding this comment.
Option instead of Formats?
| @@ -83,7 +80,7 @@ public virtual async Task<PresentationCandidates[]> FindCredentialCandidates(IEn | |||
| return result.ToArray(); | |||
| } | |||
|
|
|||
| private async Task<List<ICredential>> GetMatchingCredentials(InputDescriptor inputDescriptor) | |||
| private async Task<List<ICredential>> GetMatchingCredentials(InputDescriptor inputDescriptor, Formats? supportedFormatSigningAlgorithms) | |||
There was a problem hiding this comment.
Option< Formats > instead of Formats?
Signed-off-by: kenkosmowski <[email protected]>
kenkosmowski
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
add support for vp_format