Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add basic ov inference for 3d detection #3987

Closed
wants to merge 60 commits into from
Closed

Conversation

sovrasov
Copy link
Contributor

Summary

A draft implementation of OV model

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Base automatically changed from kp/add_3d_det_task to develop October 2, 2024 04:23
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 21.62162% with 87 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (31823cd) to head (703fa38).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/otx/core/model/detection_3d.py 20.18% 87 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3987      +/-   ##
===========================================
+ Coverage    77.11%   77.59%   +0.47%     
===========================================
  Files          308      319      +11     
  Lines        30571    31967    +1396     
===========================================
+ Hits         23576    24805    +1229     
- Misses        6995     7162     +167     
Flag Coverage Δ
py310 77.58% <21.62%> (+0.47%) ⬆️
py311 77.56% <21.62%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the TEST Any changes in tests label Oct 9, 2024
@sovrasov sovrasov changed the base branch from develop to releases/2.3.0 October 10, 2024 10:27
@sovrasov sovrasov changed the base branch from releases/2.3.0 to develop October 10, 2024 10:32
@sovrasov sovrasov closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants