Fix Tokenizer for several added special tokens #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: tokenizers
pavel-esir
commented
Jan 30, 2025
pavel-esir
force-pushed
the
fix_for_several_added_tokens
branch
from
bed040d to
d6c7419
Compare
pavel-esir
commented
Jan 30, 2025
| std::shared_ptr<ov::Node> combine_seg_node; | ||
| for (auto node: model->get_ordered_ops()) { | ||
| if (strcmp(node->get_type_info().name, "CombineSegments") == 0) { | ||
| combine_seg_node = node; | ||
| } | ||
| } | ||
| if (!combine_seg_node || combine_seg_node->input_value(1).get_element_type() != ov::element::i32) { |
There was a problem hiding this comment.
Input type is always i32, this is ensured in validate_and_infer_types()
apaniukov
approved these changes
Jan 30, 2025
is the ticket number valid? |
There was no ticket specifically for this bug, but the bug was found during work on the ticket. |
pavel-esir
commented
Jan 31, 2025
ilya-lavrenov
approved these changes
Feb 4, 2025
|
Please, fix: |
Done. |
…ead weak ptr Exception
pavel-esir
force-pushed
the
fix_for_several_added_tokens
branch
from
253f8b4 to
e96c619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flux
black-forest-labs/FLUX.1-devadds special tokens to the end as well andov_genai.Tokenizerwas correctly handling such cases.Ticket: CVS-157356