Add LongBench validation #1220
Open
Add LongBench validation #1220
+359
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: continuous batching
l-bat
force-pushed
the
lt/eval_longbench
branch
from
6c96bd0 to
eefe4f2
Compare
|
is it still valid? |
l-bat
force-pushed
the
lt/eval_longbench
branch
from
000d2a4 to
7eb1e54
Compare
l-bat
force-pushed
the
lt/eval_longbench
branch
from
6c3e950 to
becdf78
Compare
l-bat
force-pushed
the
lt/eval_longbench
branch
from
d71206d to
15d3c77
Compare
ilya-lavrenov
approved these changes
Feb 4, 2025
| LongBenchTestData("trec", 3.2, 2.0, 3.3), | ||
| LongBenchTestData("qasper", 5.8, 1.7, 3.6), | ||
| ]) | ||
| def test_optimized_generation_longbench(qwen2_converted_model, test_struct): |
There was a problem hiding this comment.
is it explicitly not marked as @pytest.mark.precommit ?
how long does this test take?
There was a problem hiding this comment.
Yes
On my local machine it takes 24 minutes, but on CI it takes about 60 minutes.
There was a problem hiding this comment.
Can we run this test in nightly jobs?
There was a problem hiding this comment.
yes, please add mark for nightly
AlexKoff88
reviewed
Feb 4, 2025
| @@ -0,0 +1,245 @@ | |||
| import re | |||
There was a problem hiding this comment.
This code is probably taken from 3rd party repo. We need to keep the license in this case.
l-bat
force-pushed
the
lt/eval_longbench
branch
from
15d3c77 to
1e88d10
Compare
l-bat
commented
Feb 4, 2025
Comment on lines
+1
to
+8
| # Copyright (C) 2023-2025 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # This file includes utility functions copied from the LongBench repository: | ||
| # https://github.com/THUDM/LongBench | ||
| # | ||
| # Copyright (c) 2023 THU-KEG & Zhipu AI | ||
| # Licensed under the MIT License |
There was a problem hiding this comment.
@moslex please take a look at the license. Could you confirm if it is sufficient for code adapted from a 3rd party repo?
AlexKoff88
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.