TL/MLX5: add nonblocking cudaMemcpy support #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MamziB
force-pushed
the
mamzi/mcast-nb-cudacopy
branch
from
cd6c065 to
363a044
Compare
MamziB
changed the title
janjust
approved these changes
Nov 1, 2024
|
Please fix linter |
|
@MamziB rebase, and fix CI, then good to go |
janjust
approved these changes
Nov 14, 2024
MamziB
force-pushed
the
mamzi/mcast-nb-cudacopy
branch
2 times, most recently
from
d754374 to
ff3cecf
Compare
|
@Sergei-Lebedev can you please take a look? all the tests now are passing |
|
@Sergei-Lebedev thanks for the new comments. please take a look at my responses and let me know your thoughts. |
|
Can one of the admins verify this patch? |
MamziB
force-pushed
the
mamzi/mcast-nb-cudacopy
branch
2 times, most recently
from
bdf3b74 to
4104cc9
Compare
|
@Sergei-Lebedev i made the two requested changes. please take a look |
|
bot: retest |
Sergei-Lebedev
approved these changes
Dec 20, 2024
MamziB
force-pushed
the
mamzi/mcast-nb-cudacopy
branch
from
4104cc9 to
084a9c5
Compare
MamziB
force-pushed
the
mamzi/mcast-nb-cudacopy
branch
from
084a9c5 to
4a3ffca
Compare
|
@janjust All the checks have passed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for nonblocking cuda memcpy in mcast