Improve session handling while fetching vehicle blocks

opentransportro · Mar 18, 2024 · 97b675c · 97b675c
1 parent e6be215
commit 97b675c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java b/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java
@@ -398,14 +398,12 @@ public Collection<IpcVehicle> getVehiclesForBlocks() {
     @Override
     public Collection<IpcVehicleToBlockConfig> getVehicleToBlockConfig(String blockId) {
         List<IpcVehicleToBlockConfig> result = new ArrayList<>();
-        Session session = HibernateUtils.getSession();
-        try {
+        try (Session session = HibernateUtils.getSession()){
             for (VehicleToBlockConfig vTBC : VehicleToBlockConfig.getVehicleToBlockConfigsByBlockId(session, blockId)) {
                 result.add(new IpcVehicleToBlockConfig(vTBC));
             }
-            session.close();
         } catch (Exception ex) {
-            session.close();
+            logger.error("Something happened while fetching the VehicleToBlockConfig.", ex);
         }
         return result;
     }