Cleanup of control code, enable MSAA, improvements to event handling #86
Conversation
There was a problem hiding this comment.
These are generally solid changes. Feel free to ignore anything marked Nitpick based on your judgement.
Much of this comes down to personal style, but I do strongly feel that the DxGLFramebuffer helped clarity of the code by keeping the single responsibility principle.
This was clearly separated from the Renderer, which operates on the Framebuffer.
Generally I try to design around deeper object composition hierarchies rather than larger objects as it helps keep the level of discoverability very high.
If we do end up keeping the DxGLFramebuffer class, one improvement that would fit well in this theme would be to not execute the GL and DX logic in the constructor - I really didn't like that, and it should likely have been in a static factory method instead.
Thanks again for doing this - I hope the review comments are helpful.
…ared context, every control gets it's own OpenGL context.
Enabled nullable reference types for the project. Removed use of var.
NogginBops
changed the title
The goal of this PR is to remove some layers of complexity from the control by both removing some of the bad abstractions introduced as well as introduce diligent error checking which will aid immensely with further development of the control.
Fixes #97
Fixes #115
Fixes #126
Fixes #118
Fixes #64
Fixes #38
Fixes #70
Fixes #82