Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruizhi] OpenTweet #5

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Ruizhi] OpenTweet #5

wants to merge 11 commits into from

Conversation

dtmelrz
Copy link

@dtmelrz dtmelrz commented Jan 16, 2024 •
edited
Loading

Minimum requirement

  • Fork the repo
  • Parse the json file included in the project
  • Display the tweets in the order the json file defines them. The app should display the author, the tweet and the date it was tweeted at. Tweets are variable length, so the cells must be properly sized to the content
  • When done, send a pull request to this project

Bonuses (in no particular order)

  • Highlight the mentions (@username) and/or links in a different font/color
  • Display a tweet's thread when tapping on a giving tweet. Due to the very simplistic data model made available to you, it's probably best to simplify this: if the user taps on the first tweet of a thread, display all the replies in ascending chronological order, if the user taps on a reply to another tweet, only show the tapped tweet and the tweet it's replying to.
  • Display avatar images (usig NSURLSession)
  • Preview a tweet when its associated cell is long pressed

Description

*I suggest reviewing the PR commit by commit - each commit should explain itself by its title & description:)
Here is a walkthrough of the MVVM architecture in this project,

Feed/Timeline
Tweet(model) <-------> TimelineViewModel <-------> TimelineViewController (View)

Thread display
Tweet(model) <-------> TweetViewModel <-------> TweetViewController (View)

Utils
--FormatDateUtils for date formatting
-- Networks for network call(s)

Things to improve

  • Show each tweet and its replies in a nested layout
  • Expandable(collapsable) table view e.g when a cell is collapse, only the tweet would show; when it is expanded, the tweet's replies would show below
  • Support pagination/infinite scroll
  • Interactions on the avatar and the mention of each tweet

Demo

Screenshot 2024-01-15 at 10 42 27 PM Screenshot 2024-01-15 at 10 42 43 PM Screenshot 2024-01-15 at 10 43 57 PM Screenshot 2024-01-15 at 10 44 27 PM
open_tweet_demo.mov

Dante Li added 11 commits January 14, 2024 11:10
Use programmatic nav instead of main storyboard.
d20f300
Define data model.
ef81b07
Draft the viewmodel with data loading function.
d06e0ff 
Also tested if the data is properly decoded from the local file.
Add tableViewCell and implement tabeleView logic
28a31ba 
Establish the data pipeline between VC and VM.
Format the ISO 8601 time points into more readable date strings.
f587fa5
Bonus 0: Display avatar images.
8c497b4
Bonus 1: Highlight the links (if there're any) on the content label.
2610d26
Increase the tweet cell's paddings around content.
78fb4d5
Bonus 2: Long press a cell to show associated tweet.
4bb06f9 
Also, click a cell to navigate to the tweet's details in a VC.
Bonus 3: Display a tweet's thread when tapping.
75937e8 
1. Prefetch the "reply to" tweet and replies for each tweet
2. Display the thread consisting of "reply to" and replies on another VC
3. make sure tweet(s) of each section presenting in ascending chronological order
Adjust comments and code format.
3dde39e
@dtmelrz dtmelrz changed the title [Ruizhi] Open Tweet [Ruizhi] OpenTweet Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtmelrz