This repository has been archived by the owner on Aug 1, 2019. It is now read-only.
Print hook output in real time #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes hooks are used to run various types of linting or tests, e.g., for pre-review. These can take a while, and if they print progress indicators, it's useful to see them immediately. Previously they wouldn't be printed at all unless there was a failure, and then all output would suddenly be printed. This makes it look like git-review is hanging. If hooks want to only print output on failure, they can buffer the output themselves however they like. As far as I can tell, the new behavior matches behavior of built-in git hooks like pre-commit, which do seem to print output immediately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes hooks are used to run various types of linting or tests, e.g.,
for pre-review. These can take a while, and if they print progress
indicators, it's useful to see them immediately. Previously they
wouldn't be printed at all unless there was a failure, and then all
output would suddenly be printed. This makes it look like git-review is
hanging. If hooks want to only print output on failure, they can buffer
the output themselves however they like.
As far as I can tell, the new behavior matches behavior of built-in git
hooks like pre-commit, which do seem to print output immediately.