Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config Composition section to support custom search parameters #3695

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Jan 21, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3532

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 50.31056% with 80 lines in your changes missing coverage. Please review.

Project coverage is 38.6%. Comparing base (a790c9d) to head (359bccf).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...tion/customsearch/SearchParametersConfigService.kt 0.0% 49 Missing ⚠️
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 61.8% 17 Missing and 4 partials ⚠️
...ne/util/extension/CompositionResourceExtensions.kt 75.0% 2 Missing and 3 partials ⚠️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 55.5% 2 Missing and 2 partials ⚠️
...ircore/engine/util/extension/ReferenceExtension.kt 50.0% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (50.3%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3695     +/-   ##
=========================================
- Coverage     38.6%   38.6%   -0.1%     
- Complexity    1168    1212     +44     
=========================================
  Files          286     290      +4     
  Lines        15291   15608    +317     
  Branches      2697    2738     +41     
=========================================
+ Hits          5907    6027    +120     
- Misses        8536    8726    +190     
- Partials       848     855      +7     
Flag Coverage Δ
engine 60.4% <40.8%> (-2.5%) ⬇️
geowidget 16.0% <ø> (ø)
quest 25.8% <63.2%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...smartregister/fhircore/engine/FhirEngineWrapper.kt 100.0% <100.0%> (ø)
...core/engine/configuration/ConfigurationRegistry.kt 61.2% <100.0%> (-10.8%) ⬇️
...hircore/engine/util/extension/ResourceExtension.kt 67.1% <ø> (-0.4%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 70.5% <100.0%> (+4.3%) ⬆️
...t/ui/sdc/qrCode/EditTextQrCodeViewHolderFactory.kt 63.6% <100.0%> (+2.6%) ⬆️
...ircore/engine/util/extension/ReferenceExtension.kt 57.1% <50.0%> (-14.3%) ⬇️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 10.2% <55.5%> (+4.0%) ⬆️
...ne/util/extension/CompositionResourceExtensions.kt 75.0% <75.0%> (ø)
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 60.6% <61.8%> (-2.6%) ⬇️
...tion/customsearch/SearchParametersConfigService.kt 0.0% <0.0%> (ø)

... and 18 files with indirect coverage changes

@LZRS LZRS force-pushed the 3532-custom-search-param branch from 1db3ecb to 292dc8b Compare January 22, 2025 00:08
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 292dc8b to 50ccdce Compare January 22, 2025 22:38
@LZRS LZRS requested review from ellykits and Rkareko January 27, 2025 07:02
@LZRS LZRS marked this pull request as ready for review January 27, 2025 07:02
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 95a4c35 to be693fc Compare February 3, 2025 22:59
to check if resolves OOM
@LZRS LZRS force-pushed the 3532-custom-search-param branch from be693fc to c564467 Compare February 5, 2025 22:00
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 039e546 to 5704068 Compare February 6, 2025 08:42
@LZRS LZRS force-pushed the 3532-custom-search-param branch 2 times, most recently from 25f2ad2 to a261a79 Compare February 12, 2025 10:57
@LZRS LZRS force-pushed the 3532-custom-search-param branch from a261a79 to ec1a9cc Compare February 12, 2025 13:42
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 7b3fb7f to cd232e1 Compare February 13, 2025 23:08
@LZRS LZRS force-pushed the 3532-custom-search-param branch 2 times, most recently from d130d76 to ed9369b Compare February 17, 2025 23:25
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 81d2e0a to a354ce9 Compare February 18, 2025 00:03
@ellykits ellykits marked this pull request as draft February 18, 2025 09:40
@ellykits ellykits added the Discussion This is an open discussion that may or may not lead to actionable points label Feb 18, 2025
@f-odhiambo f-odhiambo added the DNM DO NOT MERGE label Feb 18, 2025
com.google.android.gms.common.api.ApiException: 17: API: LocationServices.API is not available on this device. Connection failed with: ConnectionResult{statusCode=SERVICE_INVALID, resolution=null, message=null}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion This is an open discussion that may or may not lead to actionable points DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the process of adding custom search parameters to be configurable
4 participants