Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23019: Enable FIPS 4.12 #116

Open
wants to merge 3 commits into
base: release-4.12
Choose a base branch
from
Open

OCPBUGS-23019: Enable FIPS 4.12 #116

wants to merge 3 commits into from
+64 −111

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Sep 5, 2024

No description provided.

adrianchiris and others added 3 commits September 5, 2024 01:32
@adrianchiris @vrindle
cleanup makefile
8bcba45 
- cleanup makefile
- update workflows
- remove deprecated linters from .golangci.yml

Signed-off-by: adrianc <[email protected]>
@bn222 @vrindle
Allow to override go tags in build
b8cc5c0 
Signed-off-by: Balazs Nemeth <[email protected]>
@vrindle
Ensure FIPS compliance when building device plugin
047004e
@vrindle vrindle changed the title Fix 4.12 Enable FIPS 4.12 Sep 5, 2024
@vrindle vrindle changed the title Enable FIPS 4.12 OCPBUGS-23019: Enable FIPS 4.12 Sep 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 5, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-23019, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23018 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 5, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-23019, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23018 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

@vrindle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor

bn222 commented Sep 5, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@bn222
Copy link
Contributor

bn222 commented Sep 11, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 11, 2024
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Oct 3, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-23019, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23018 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Oct 11, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-23019, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23018 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123

@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@evgenLevin evgenLevin

@qiowang721 qiowang721

@ajaggapa ajaggapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.