OCPQE-21002 - Review 4.14 upgrade ci jobs and add missing jobs #60384
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dis016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @JianLi-RH @jiajliu |
| cluster_profile: aws-1-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| E2E_RUN_TAGS: '@disconnected' |
There was a problem hiding this comment.
We don't need TEST_FILTERS anymore.
| @@ -74,6 +74,19 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test-disconnected | |||
| workflow: cucushift-installer-rehearse-aws-c2s-ipi-disconnected-private | |||
| - as: aws-ipi-disc-priv-localzone-fips-f28 | |||
There was a problem hiding this comment.
We have aws-ipi-disc-priv-mtu-localzone-fips-f28 covers similar workflow, so we don't need to add aws-ipi-disc-priv-localzone-fips-f28.
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-aws-ipi-edge-zone-byo-subnet-sdn | ||
| - as: aws-ipi-localzone-fips-f28 |
There was a problem hiding this comment.
Above 2 jobs already cover this profile, so we can remove it.
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-aws-sc2s-ipi-disconnected-private | ||
| - as: aws-usgov-ipi-disc-priv-f28 |
There was a problem hiding this comment.
I think aws-usgov-ipi-private-f28 already covers normal cluster, so we can remove the disc one.
| @@ -233,6 +351,15 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-azure-mag-ipi | |||
| - as: azure-mag-ipi-fullyprivate-f28 | |||
There was a problem hiding this comment.
I think we can remove above job azure-mag-ipi-fips-f28
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| test: | ||
| - chain: openshift-e2e-test-qe |
There was a problem hiding this comment.
Normal upgrade job requires openshift-upgrade-qe-test chaine. Please update all of them.
| @@ -183,6 +310,48 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-aws-usgov-ipi-private-cco-manual-security-token-service | |||
| - as: aws-usgov-ipi-private-workers-marketplace-f28 | |||
There was a problem hiding this comment.
Please remove aws-usgov-ipi-private-f60
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-azure-mag-ipi-fullyprivate | ||
| - as: azure-stack-ipi-f28 |
There was a problem hiding this comment.
Dup with azure-stack-ipi-proxy-fips-f28, please remove this one
| @@ -201,6 +382,85 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-azure-ipi-workers-rhel8 | |||
| - as: azure-mag-ipi-fips-f28 | |||
There was a problem hiding this comment.
We have other jobs already covered azure-mag-ipi and fips, so we can remove this one
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: baremetal-lab-upi | ||
| - as: baremetal-upi-ovn-ipv4-f28 |
There was a problem hiding this comment.
Dup with baremetal-upi-ovn-ipv4-compact-f28, so remove this one
| @@ -214,6 +474,45 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test-hypershift | |||
| workflow: cucushift-installer-rehearse-baremetalds-assisted-hypershift-agent-mce-guest | |||
| - as: baremetalds-ipi-ovn-dualstack-primaryv6-f28 | |||
There was a problem hiding this comment.
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-gcp-ipi-minimal-permission | ||
| - as: gcp-ipi-proxy-etcd-encryption-f28-compliance |
There was a problem hiding this comment.
| test: | ||
| - ref: openshift-extended-test | ||
| - ref: openshift-extended-web-tests | ||
| - ref: openshift-e2e-test-qe-report |
There was a problem hiding this comment.
Looks like this is only for e2e case, we can remove this job.
@dis016 If we don'g need this job, please add keywords -compliance and template in get_missed_upgrade_jobs.py. You can submit a new PR.
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-nutanix-ipi-boot-categories-project | ||
| - as: nutanix-ipi-compact-image-registry-s3-f28 |
There was a problem hiding this comment.
Please refer to https://github.com/openshift/release/pull/60384/files#r1906215714
and you can also add keyword to get_missed_upgrade_jobs.py if we really don't need to cover this in upgrade job.
| test: | ||
| - chain: openshift-e2e-test-qe-automated-release | ||
| workflow: cucushift-installer-rehearse-vsphere-ipi-disconnected | ||
| - as: vsphere-ipi-disk-encryption-tang-fips-f28 |
There was a problem hiding this comment.
@jinyunma Could you please help confirm if we need to cover this profile in upgrade ci? thanks
| @@ -94,6 +106,18 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-aws-ipi-byo-route53-registry-s3-cloudfront | |||
| - as: aws-ipi-imdsv2-arm-f28 | |||
There was a problem hiding this comment.
Dup to aws-ipi-imdsv2-fips-amd-f28
| - as: aws-ipi-sdn-arm-f28 | ||
| cron: 4 9 3 * * | ||
| steps: |
There was a problem hiding this comment.
I think sdn network is the default network in OCP 4.14. so we don't need to add this job.
@zhaozhanqi @jianlinliu Please correct me if I am wrong.
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-azure-ipi-capability-baselinecaps-vset-additionalcaps | ||
| - as: azure-ipi-basecap-vset-arm-f28 |
There was a problem hiding this comment.
We can keep one is enough azure-ipi-basecap-vset-additionalcap-arm-f28 and azure-ipi-basecap-vset-arm-f28, I prefer tp keep azure-ipi-basecap-vset-additionalcap-arm-f28, because arm is more cheap
| SIZE_VARIANT: compact | ||
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-azure-ipi-ovn-etcd-encryption | ||
| - as: azure-ipi-ovn-ipsec-arm-mixarch-day2-f28 |
There was a problem hiding this comment.
Could you please help remove this job?
There was a problem hiding this comment.
Need to remove both azure-ipi-oidc-mini-perm-arm-f28 and azure-ipi-ovn-etcd-encryption-compact-arm-f28 the jobs?
| @@ -218,6 +376,41 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-azure-ipi-ingress-custom-controller | |||
| - as: azure-ipi-mini-perm-arm-f28 | |||
There was a problem hiding this comment.
dup to azure-ipi-oidc-mini-perm-arm-f28
| OCP_ARCH: arm64 | ||
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-aws-ipi-ingress-lbtype-classic |
There was a problem hiding this comment.
@jianlinliu We already have cucushift-installer-rehearse-aws-ipi-ingress-lbtype-nlb, do you think we still need classic?
| WORKER_INSTANCE_TYPE: m6g.xlarge | ||
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-aws-upi | ||
| - as: azure-ipi-arm-mixarch-day2-f60 |
There was a problem hiding this comment.
@dis016 Could you help remove this one? it's a duplicate to azure-ipi-arm-mixarch-f60
| @@ -265,6 +489,86 @@ tests: | |||
| test: | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-azure-upi | |||
| - as: azure-upi-mini-perm-arm-f28 | |||
There was a problem hiding this comment.
We can remove azure-upi-arm-f60 if we add azure-upi-mini-perm-arm-f28
| test: | ||
| - chain: openshift-e2e-test-qe | ||
| workflow: cucushift-installer-rehearse-azure-upi-minimal-permission | ||
| - as: baremetal-ipi-ovn-dualstack-amd-vmedia-f28 |
There was a problem hiding this comment.
Same baremetal rule, let's wait the reply from @sgoveas
baremetal-ipi-ovn-dualstack-amd-vmedia-f28
baremetal-ipi-ovn-ipv4-fips-vmedia-amd-f28
There was a problem hiding this comment.
We can skip baremetal-ipi-ovn-ipv4-fips-vmedia-amd-f28
| @@ -280,6 +584,27 @@ tests: | |||
| - ref: ipi-install-heterogeneous | |||
| - chain: openshift-upgrade-qe-test | |||
| workflow: cucushift-installer-rehearse-gcp-ipi-ovn-ipsec | |||
| - as: gcp-ipi-proxy-etcd-encryption-arm-f28 | |||
There was a problem hiding this comment.
We have other jobs covered proxy and etcd-encryption, so we can remove this one.
|
[REHEARSALNOTIFIER]
A total of 134 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@dis016: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OCPQE-21002 - Review 4.14 upgrade ci jobs and add missing jobs