Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dummy PR for a new peer reviewer to practice #87384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jan 22, 2025

This is a dummy PR for a new peer reviewer to practice a peer review.

Version(s): 4.16+

Issue:

Link to docs preview:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 22, 2025

🤖 Wed Jan 22 10:58:20 - Prow CI generated the docs preview:

https://87384--ocpdocs-pr.netlify.app/

@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@xenolinux
Copy link
Contributor Author

Deleting Vale comments as this is a PR to practice.

@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@xenolinux xenolinux added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

@xenolinux: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@openshift openshift deleted a comment from ocpdocs-vale-bot Jan 22, 2025
@xenolinux
Copy link
Contributor Author

@shreyasiddhartha This PR is ready for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants