OCPBUGS-38468: use default route mtu #4315

eslutsky · 2024-12-12T11:52:41Z

determine if the host has a default gateway based on IPv4 or IPv6 routes, then use its MTU,
the original solution was based on net.GetHostIP which didn't cover cases when we dont have any network connection (hardcoded nodeIP with loopback) .

openshift-ci · 2024-12-12T11:52:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2024-12-12T11:52:48Z

@eslutsky: This pull request references Jira Issue OCPBUGS-38468, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eslutsky · 2024-12-12T11:53:30Z

/test metal-periodic-test

openshift-ci · 2024-12-12T11:53:33Z

@eslutsky: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-optional-components-rhel-eus

/test ocp-full-conformance-optional-components-rhel-eus-arm

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-rhel-eus-arm

/test ocp-full-conformance-serial-optional-components-rhel-eus

/test ocp-full-conformance-serial-optional-components-rhel-eus-arm

/test ocp-full-conformance-serial-rhel-eus

/test ocp-full-conformance-serial-rhel-eus-arm

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus-arm

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus-arm

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test metal-periodic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

eslutsky · 2024-12-12T12:31:40Z

/test e2e-aws-tests-periodic

eslutsky · 2024-12-13T16:00:23Z

/test e2e-aws-tests-periodic

openshift-ci-robot · 2024-12-16T12:07:40Z

@eslutsky: This pull request references Jira Issue OCPBUGS-38468, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

introduce parser for "/proc/net/route" to determine if the host has a default gateway set, then use its MTU,
the original solution was based on net.GetHostIP which didn't cover cases when we dont have any network connection (hardcoded nodeIP with loopback) .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eslutsky · 2024-12-16T12:58:17Z

/test e2e-aws-tests-periodic

eslutsky · 2024-12-16T14:59:04Z

/test verify

ggiguash · 2025-01-07T11:26:53Z

/retest

eslutsky · 2025-01-13T17:11:54Z

/retest

eslutsky · 2025-01-14T10:38:35Z

logs related to those failures ,
from the journal:

Jan 13 17:33:43 i-0f899d7309062d8a9 microshift[57347]: infrastructure-services-manager W0113 17:33:43.952196   57347 components.go:37] Failed to start CNI plugin: failed to validate ovn-kubernetes configuration: failed to validate OVN-K configuration: interface MTU (1500) is too small for specified overlay (9001)
Jan 13 17:33:43 i-0f899d7309062d8a9 microshift[57347]: infrastructure-services-manager I0113 17:33:43.952225   57347 startuprecorder.go:58] "SERVICE READY" service="infrastructure-services-manager" since-start="21.508052857s"
Jan 13 17:33:43 i-0f899d7309062d8a9 microshift[57347]: infrastructure-services-manager E0113 17:33:43.952219   57347 manager.go:138] "SERVICE FAILED - stopping MicroShift" err="failed to validate ovn-kubernetes configuration: failed to validate OVN-K configuration: interface MTU (1500) is too small for specified overlay (9001)" service="infrastructure-services-manager" since-start="21.508041643s"

eslutsky · 2025-01-14T10:59:04Z

/test e2e-aws-tests-arm

pacevedom · 2025-01-17T13:35:06Z

pkg/util/net.go

@@ -266,3 +274,55 @@ func GetHostIPv6(ipHint string) (string, error) {

 	return "", fmt.Errorf("unable to find host IPv6 address")
 }
+
+// Find the Default route Interface based on ipv4 or ipv6 routes.
+func FindDefaultRouteIface() (iface *tcpnet.Interface, err error) {


I think we need to pass the configuration here to determine if MicroShift is running on ipv4, ipv6, or both.
Imagine you have different NICs in the host for each IP family. Default routes would be configured on different devices, therefore they could have different MTUs.
If MicroShift is running on ipv6 check only ipv6 routes.
If MicroShift is running on ipv4 check only ipv4 routes.
If MicroShift is running on both, check both and pick the smallest.
Or is there something I am missing?

I'm not sure its a common scenario for edge devices when you have different Default routes set across different IP families .

we are calling FindDefaultRouteIface from the ovn package which have its own configuration. the IPv4/6 detection logic is in the config struct .

eslutsky · 2025-01-20T20:12:33Z

/retest

pkg/components/networking.go

pkg/config/ovn/ovn.go

pkg/util/net.go

eslutsky · 2025-01-21T13:31:34Z

/test e2e-aws-tests-bootc

eslutsky · 2025-01-21T13:31:46Z

/test e2e-aws-tests-bootc-arm

eslutsky · 2025-01-21T20:19:23Z

/test e2e-aws-tests-bootc

Signed-off-by: Evgeny Slutsky <[email protected]>

pacevedom

/lgtm

openshift-ci · 2025-01-22T14:26:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [eslutsky,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-01-22T16:37:28Z

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-01-22T16:41:24Z

@eslutsky: Jira Issue OCPBUGS-38468 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

determine if the host has a default gateway based on IPv4 or IPv6 routes, then use its MTU,
the original solution was based on net.GetHostIP which didn't cover cases when we dont have any network connection (hardcoded nodeIP with loopback) .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 12, 2024

openshift-ci bot requested a review from jogeo December 12, 2024 11:52

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024

eslutsky force-pushed the OCPBUGS-38468-2 branch 2 times, most recently from c934c8f to c044607 Compare December 13, 2024 15:59

eslutsky force-pushed the OCPBUGS-38468-2 branch 3 times, most recently from 84c39e3 to 97da4ad Compare December 16, 2024 11:58

eslutsky force-pushed the OCPBUGS-38468-2 branch from 97da4ad to 5c5bb6e Compare December 16, 2024 14:58

eslutsky marked this pull request as ready for review December 17, 2024 16:41

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024

openshift-ci bot requested review from copejon and ggiguash December 17, 2024 16:41

eslutsky force-pushed the OCPBUGS-38468-2 branch from 5c5bb6e to cd512cc Compare January 13, 2025 17:11

eslutsky force-pushed the OCPBUGS-38468-2 branch from cd512cc to 46423ba Compare January 14, 2025 14:32

eslutsky force-pushed the OCPBUGS-38468-2 branch 4 times, most recently from eef83e2 to 89b0f65 Compare January 17, 2025 10:46

pacevedom reviewed Jan 17, 2025

View reviewed changes

eslutsky force-pushed the OCPBUGS-38468-2 branch 7 times, most recently from 6722393 to 864423c Compare January 20, 2025 16:28

eslutsky force-pushed the OCPBUGS-38468-2 branch from 864423c to 8e384fb Compare January 20, 2025 23:29

pacevedom reviewed Jan 21, 2025

View reviewed changes

pkg/components/networking.go Outdated Show resolved Hide resolved

pkg/config/ovn/ovn.go Outdated Show resolved Hide resolved

pkg/config/ovn/ovn.go Outdated Show resolved Hide resolved

pkg/util/net.go Outdated Show resolved Hide resolved

pkg/util/net.go Outdated Show resolved Hide resolved

eslutsky force-pushed the OCPBUGS-38468-2 branch 2 times, most recently from 5f436e7 to f7fd5ec Compare January 21, 2025 10:43

eslutsky force-pushed the OCPBUGS-38468-2 branch from f7fd5ec to b7935e7 Compare January 22, 2025 11:04

OCPBUGS-38468: use default route mtu

fb380ce

Signed-off-by: Evgeny Slutsky <[email protected]>

eslutsky force-pushed the OCPBUGS-38468-2 branch from b7935e7 to fb380ce Compare January 22, 2025 13:38

pacevedom approved these changes Jan 22, 2025

View reviewed changes

openshift-ci bot assigned pacevedom Jan 22, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025

openshift-merge-bot bot merged commit 1ef3eb4 into openshift:main Jan 22, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-38468: use default route mtu #4315

OCPBUGS-38468: use default route mtu #4315

eslutsky commented Dec 12, 2024 •

edited

Loading

openshift-ci bot commented Dec 12, 2024

openshift-ci-robot commented Dec 12, 2024

eslutsky commented Dec 12, 2024

openshift-ci bot commented Dec 12, 2024

eslutsky commented Dec 12, 2024

eslutsky commented Dec 13, 2024

openshift-ci-robot commented Dec 16, 2024

eslutsky commented Dec 16, 2024

eslutsky commented Dec 16, 2024

ggiguash commented Jan 7, 2025

eslutsky commented Jan 13, 2025

eslutsky commented Jan 14, 2025

eslutsky commented Jan 14, 2025

pacevedom Jan 17, 2025

eslutsky Jan 17, 2025

eslutsky Jan 17, 2025 •

edited

Loading

eslutsky commented Jan 20, 2025

eslutsky commented Jan 21, 2025

eslutsky commented Jan 21, 2025

eslutsky commented Jan 21, 2025

pacevedom left a comment

openshift-ci bot commented Jan 22, 2025

openshift-ci bot commented Jan 22, 2025

openshift-ci-robot commented Jan 22, 2025

OCPBUGS-38468: use default route mtu #4315

OCPBUGS-38468: use default route mtu #4315

Conversation

eslutsky commented Dec 12, 2024 • edited Loading

openshift-ci bot commented Dec 12, 2024

openshift-ci-robot commented Dec 12, 2024

eslutsky commented Dec 12, 2024

openshift-ci bot commented Dec 12, 2024

eslutsky commented Dec 12, 2024

eslutsky commented Dec 13, 2024

openshift-ci-robot commented Dec 16, 2024

eslutsky commented Dec 16, 2024

eslutsky commented Dec 16, 2024

ggiguash commented Jan 7, 2025

eslutsky commented Jan 13, 2025

eslutsky commented Jan 14, 2025

eslutsky commented Jan 14, 2025

pacevedom Jan 17, 2025

Choose a reason for hiding this comment

eslutsky Jan 17, 2025

Choose a reason for hiding this comment

eslutsky Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

eslutsky commented Jan 20, 2025

eslutsky commented Jan 21, 2025

eslutsky commented Jan 21, 2025

eslutsky commented Jan 21, 2025

pacevedom left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 22, 2025

openshift-ci bot commented Jan 22, 2025

openshift-ci-robot commented Jan 22, 2025

eslutsky commented Dec 12, 2024 •

edited

Loading

eslutsky Jan 17, 2025 •

edited

Loading