-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46072: create /run/nodeip-configuration before use #4798
base: master
Are you sure you want to change the base?
Conversation
With nmstate `br-ex` creation using static IP, it looks like the systemd boot ordering can change and we can attempt to run `30-resolv-prepender` before `nodeip-configuration.service`. When `30-resolv-prepender` runs it tries to touch a file in `/run/nodeip-configuration` when it does not exist. ```log nm-dispatcher[2409]: touch: cannot touch '/run/nodeip-configuration/br-ex-up': No such file or directory ``` The quick fix is to always mkdir before touching, then we don't have to track the global state of `/run/nodeip-configuration`
@rbbratta: This pull request references Jira Issue OCPBUGS-46072, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@cybertron: This pull request references Jira Issue OCPBUGS-46072, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: rbbratta. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron, rbbratta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@rbbratta: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/uncc pierreprinetti |
With nmstate
br-ex
creation using static IP, it looks like the systemd boot ordering can change and we can attempt to run30-resolv-prepender
beforenodeip-configuration.service
.When
30-resolv-prepender
runs it tries to touch a file in/run/nodeip-configuration
when it does not exist.The quick fix is to always mkdir before touching, then we don't have to track the global state of
/run/nodeip-configuration