Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for installer testing #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhixson74
Copy link
Member

Integration test

Requires setting environmental variables
To test, cd pkg/installer && go test -tags=aro

Generates ignition files & manifests

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhixson74
Once this PR has been reviewed and has the lgtm label, please assign rogbas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhixson74
Copy link
Member Author

/cc @patrickdillon @zaneb

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@@ -45,3 +58,193 @@ func TestVMNetworkingType(t *testing.T) {
})
}
}

func TestApplyInstallConfigCustomisations(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to go in a separate file and be protected by an explicit build tag (like e.g. // +build integration), since this can't ever pass in CI.

@jewzaam jewzaam removed their request for review December 2, 2024 13:25
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 9ee4c62 link true /test unit
ci/prow/lint 9ee4c62 link true /test lint
ci/prow/validate 9ee4c62 link true /test validate
ci/prow/vendor 9ee4c62 link true /test vendor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants