-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for installer testing #219
base: main
Are you sure you want to change the base?
Add integration test for installer testing #219
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0cb4fc7
to
9ee4c62
Compare
/cc @patrickdillon @zaneb |
@@ -45,3 +58,193 @@ func TestVMNetworkingType(t *testing.T) { | |||
}) | |||
} | |||
} | |||
|
|||
func TestApplyInstallConfigCustomisations(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to go in a separate file and be protected by an explicit build tag (like e.g. // +build integration
), since this can't ever pass in CI.
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Integration test
Requires setting environmental variables
To test, cd pkg/installer && go test -tags=aro
Generates ignition files & manifests