OCPBUGS-46513: Add ConsolePluginContentSecurityPolicy feature gate to… #957
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-important
|
@TheRealJon: This pull request references Jira Issue OCPBUGS-46513, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
TheRealJon
force-pushed
the
OCPBUGS-46513
branch
from
1c5ba45 to
983dadb
Compare
| @@ -220,9 +220,11 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle | |||
| return err | |||
| } | |||
|
|
|||
| contentSecurityPolicyEnabled := featureGates.Enabled("ConsolePluginContentSecurityPolicy") | |||
There was a problem hiding this comment.
Hey, @JoelSpeed. Would you mind confirming this is right for content security policy? We're disabling some behavior in console if the gate is not enabled.
I wish we had named this ConsoleContentSecurityPolicy rather than ConsolePluginContentSecurityPolicy, but I assume it's too late for that (at least for 4.18?).
There was a problem hiding this comment.
That will give you what you need to gate the functionality yes
And yep, a bit late to change the name unfortunately
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TheRealJon
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retest |
|
@TheRealJon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@TheRealJon: Jira Issue OCPBUGS-46513: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-46513 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console-operator |
|
/cherry-pick release-4.18 |
|
@spadgett: new pull request created: #959 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… console config