Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-2023 Implement a quickstart for netobserv operator #955

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jpinsonneau
Copy link

@jpinsonneau jpinsonneau commented Jan 15, 2025

Initial quickstart for Network Observability Operator

Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpinsonneau
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +40 to +46
2.2 If you are not using Loki, click Loki client settings and change **Enable** to **False**. The setting is True by default.

2.3 If you are using Loki, set the following specifications:

i. **spec.loki.mode**: Set this to the **LokiStack** mode, which automatically sets URLs, TLS, cluster roles and a cluster role binding, as well as the authToken value. Alternatively, the Manual mode allows more control over configuration of these settings.

ii. **spec.loki.lokistack.name**: Set this to the name of your LokiStack resource. In this documentation, loki is used.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stleerh you mentionned you would like to point out Loki Operator doc. How do you want to handle it here ?

Copy link

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little comments to add bold to GUI items, some spacing adjustments before punctuation, and adding "the" in a couple of places. Looks great! This will be nice to have indeed :)

quickstarts/install-netobserv.yaml Outdated Show resolved Hide resolved
quickstarts/install-netobserv.yaml Outdated Show resolved Hide resolved
quickstarts/install-netobserv.yaml Outdated Show resolved Hide resolved
quickstarts/install-netobserv.yaml Outdated Show resolved Hide resolved
quickstarts/install-netobserv.yaml Outdated Show resolved Hide resolved
@jpinsonneau
Copy link
Author

Just a few little comments to add bold to GUI items, some spacing adjustments before punctuation, and adding "the" in a couple of places. Looks great! This will be nice to have indeed :)

Thank you @skrthomas ! Merged your suggestions 😉

Comment on lines +18 to +19
1. In the OpenShift Container Platform web console, click **OperatorHub** from the [Operators]{{highlight qs-nav-operators}} → OperatorHub.
2. Choose **Network Observability Operator** from the list of available Operators in the OperatorHub, and click **Install**.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to provide a direct link to that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so as you usually need to search for it first 🤔
Also, it may vary depending of your catalogs

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't it what lightspeed is doing?
It seems that this link would work: /operatorhub/ns/default?details-item=netobserv-operator-redhat-operators-openshift-marketplace&channel=stable (assuming using the main official catalog)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it works if you remove the channel ?

Else I feel it's not worth. None of the existing quickstarts are doing such.

@jpinsonneau jpinsonneau marked this pull request as ready for review January 24, 2025 09:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and TheRealJon January 24, 2025 09:44
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 646d0f7 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-operator 646d0f7 link true /test e2e-aws-operator
ci/prow/e2e-azure-ovn-upgrade 646d0f7 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-console 646d0f7 link true /test e2e-aws-console
ci/prow/e2e-gcp-ovn 646d0f7 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node 646d0f7 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants