-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-2023 Implement a quickstart for netobserv operator #955
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2.2 If you are not using Loki, click Loki client settings and change **Enable** to **False**. The setting is True by default. | ||
|
||
2.3 If you are using Loki, set the following specifications: | ||
|
||
i. **spec.loki.mode**: Set this to the **LokiStack** mode, which automatically sets URLs, TLS, cluster roles and a cluster role binding, as well as the authToken value. Alternatively, the Manual mode allows more control over configuration of these settings. | ||
|
||
ii. **spec.loki.lokistack.name**: Set this to the name of your LokiStack resource. In this documentation, loki is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stleerh you mentionned you would like to point out Loki Operator doc. How do you want to handle it here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few little comments to add bold to GUI items, some spacing adjustments before punctuation, and adding "the" in a couple of places. Looks great! This will be nice to have indeed :)
Co-authored-by: Sara Thomas <[email protected]>
Co-authored-by: Sara Thomas <[email protected]>
Co-authored-by: Sara Thomas <[email protected]>
Co-authored-by: Sara Thomas <[email protected]>
Thank you @skrthomas ! Merged your suggestions 😉 |
1. In the OpenShift Container Platform web console, click **OperatorHub** from the [Operators]{{highlight qs-nav-operators}} → OperatorHub. | ||
2. Choose **Network Observability Operator** from the list of available Operators in the OperatorHub, and click **Install**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to provide a direct link to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so as you usually need to search for it first 🤔
Also, it may vary depending of your catalogs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't it what lightspeed is doing?
It seems that this link would work: /operatorhub/ns/default?details-item=netobserv-operator-redhat-operators-openshift-marketplace&channel=stable
(assuming using the main official catalog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it works if you remove the channel ?
Else I feel it's not worth. None of the existing quickstarts are doing such.
@jpinsonneau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Initial quickstart for Network Observability Operator