Find Nodes by hostname #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
honza
force-pushed
the
wip-nodeless
branch
2 times, most recently
from
e6c8c18 to
7ea5290
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
honza
force-pushed
the
wip-nodeless
branch
8 times, most recently
from
cefd980 to
6a8db86
Compare
We currently support finding Nodes: - by ProviderID when there is a cloud provider present - by label when we use kubeadm But if neither cloud provider nor kubeadm is present, there is no way to find the Nodes and assign a ProviderID to them. Here, we add a new method: matching the hostname. We change the meaning of IsProvisioned to add KubernetesNodeReady. This allows us to set the Metal3Machine as ready and give it a ProviderID while still trying to find Nodes by hostname and set the ProviderID on them.
|
@honza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support finding Nodes:
But if neither cloud provider nor kubeadm is present, there is no way to
find the Nodes and assign a ProviderID to them.
Here, we add a new method: matching the hostname.
We change the meaning of IsProvisioned to add KubernetesNodeReady. This
allows us to set the Metal3Machine as ready and give it a ProviderID
while still trying to find Nodes by hostname and set the ProviderID
on them.