Skip to content

Commit

Permalink
Addressed PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Guian Gumpac <[email protected]>
  • Loading branch information
GumpacG committed Jul 27, 2023
1 parent 61aaa8f commit d483491
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ private OpenSearchGeoPointType() {
this.properties.put("lon", new OpenSearchDataType(ExprCoreType.DOUBLE));
}

@Getter
@EqualsAndHashCode.Exclude
Map<String, OpenSearchDataType> properties;

public static OpenSearchGeoPointType of() {
return OpenSearchGeoPointType.instance;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public Pair<Double, Double> geoValue() {
}
}

// lat or lon can be null to support geopoint.lat query but both can't be null
if (lat == null && lon == null) {
throw new IllegalStateException("geo point must be in format of {\"lat\": number, \"lon\": "
+ "number}");
Expand Down

0 comments on commit d483491

Please sign in to comment.