Add support for -Dbuild.snapshot=true/false and default to building snapshot. #1409

dblock · 2021-08-17T19:16:51Z

Signed-off-by: dblock [email protected]

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Github Issue # or road-map entry, if available:

#1403

Description of changes:

Default to building a -SNAPSHOT version of this plugin.
Adds support for passing -Dbuild.snapshot=false to not build a snapshot.

The downside is that the pom.xml is incorrect for -SNAPSHOT build (contains non-snapshot version because pom.xml doesn't know anything about profiles).

Why these changes are required?

Building the end-to-end bundle needs the artifacts to be able to build snapshot vs. not snapshot.

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

The build could only produce a snapshot version vs. non-snapshot.

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

Snapshot (default)

mvn -B clean package -Padvanced -DskipTests

[INFO] -----------------< org.opensearch:opensearch-security >-----------------
[INFO] Building OpenSearch Security 1.1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------

...

[INFO] --- maven-jar-plugin:3.1.1:jar (default-jar) @ opensearch-security ---
[INFO] Building jar: /home/ubuntu/source/opensearch-project/security/dblock-security/target/opensearch-security-1.1.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- git-commit-id-plugin:2.2.6:validateRevision (validate-the-git-infos) @ opensearch-security ---
[INFO]
[INFO] --- maven-jar-plugin:3.1.1:test-jar (default) @ opensearch-security ---
[INFO] Building jar: /home/ubuntu/source/opensearch-project/security/dblock-security/target/opensearch-security-1.1.0.0-SNAPSHOT-tests.jar
[INFO]
[INFO] --- maven-assembly-plugin:3.1.1:single (plugin) @ opensearch-security ---
[INFO] Reading assembly descriptor: /home/ubuntu/source/opensearch-project/security/dblock-security/src/main/assemblies/plugin.xml
[INFO] Building zip: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0-SNAPSHOT.zip
[INFO] 
[INFO] --- maven-assembly-plugin:3.1.1:single (securityadmin) @ opensearch-security ---
[INFO] Reading assembly descriptor: /home/ubuntu/source/opensearch-project/security/dblock-security/src/main/assemblies/securityadmin-standalone.xml
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'org.opensearch:dlic*'

[INFO] Building zip: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0-SNAPSHOT-securityadmin-standalone.zip
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'org.opensearch:dlic*'

[INFO] Building tar: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0-SNAPSHOT-securityadmin-standalone.tar.gz
[INFO] 
[INFO] --- checksum-maven-plugin:1.7.1:files (default) @ opensearch-security ---
[INFO] opensearch-security-1.1.0.0-SNAPSHOT.zip - SHA-512 : e9f9434e058ddfeb3be9468889afcc46cf031c9591b79317fd0cb60cc16e6a5eda5951bfb86a5a1c1551af2b29b1e37f7bff1976c918521bdd987f888bbe73ab
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

$ unzip -p target/opensearch-security-1.1.0.0-SNAPSHOT.jar META-INF/MANIFEST.MF
Manifest-Version: 1.0
Created-By: Apache Maven 3.6.3
Build-Jdk: 14.0.2
Implementation-Title: OpenSearch Security
Implementation-Version: 1.1.0.0-SNAPSHOT <-------------------------------------------
Implementation-Vendor-Id: org.opensearch
Implementation-URL: https://github.com/opensearch-project/security
Build-Time: 2021-08-30T22:05:33Z
Built-By: Amazon OpenDistro ElasticSearch Security Parent
git-sha1: 7d3518f77f7e614e7bec8523b2c867b34f1b67d6

Not Snapshot

mvn -B clean package -Padvanced -DskipTests -Dbuild.snapshot=false

[INFO] -----------------< org.opensearch:opensearch-security >-----------------
[INFO] Building OpenSearch Security 1.1.0.0
[INFO] --------------------------------[ jar ]---------------------------------

...

[INFO] --- maven-jar-plugin:3.1.1:test-jar (default) @ opensearch-security ---
[INFO] Building jar: /home/ubuntu/source/opensearch-project/security/dblock-security/target/opensearch-security-1.1.0.0-tests.jar
[INFO] 
[INFO] --- maven-assembly-plugin:3.1.1:single (plugin) @ opensearch-security ---
[INFO] Reading assembly descriptor: /home/ubuntu/source/opensearch-project/security/dblock-security/src/main/assemblies/plugin.xml
[INFO] Building zip: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0.zip
[INFO] 
[INFO] --- maven-assembly-plugin:3.1.1:single (securityadmin) @ opensearch-security ---
[INFO] Reading assembly descriptor: /home/ubuntu/source/opensearch-project/security/dblock-security/src/main/assemblies/securityadmin-standalone.xml
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'org.opensearch:dlic*'

[INFO] Building zip: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0-securityadmin-standalone.zip
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'org.opensearch:dlic*'

[INFO] Building tar: /home/ubuntu/source/opensearch-project/security/dblock-security/target/releases/opensearch-security-1.1.0.0-securityadmin-standalone.tar.gz
[INFO] 
[INFO] --- checksum-maven-plugin:1.7.1:files (default) @ opensearch-security ---
[INFO] opensearch-security-1.1.0.0.zip - SHA-512 : 57fa1109843795d12f0c56b51e3352b1e50aa9bdaf4dbf05bb17517019c46f6f95774f0e3d020a422a9b7692dc2e4cb9e19d561101dbe0a383f226701dc4ada0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

$ unzip -p target/opensearch-security-1.1.0.0.jar META-INF/MANIFEST.MF
Manifest-Version: 1.0
Created-By: Apache Maven 3.6.3
Build-Jdk: 14.0.2
Implementation-Title: OpenSearch Security
Implementation-Version: 1.1.0.0 <------------------------------------------
Implementation-Vendor-Id: org.opensearch
Implementation-URL: https://github.com/opensearch-project/security
Build-Time: 2021-08-30T22:02:25Z
Built-By: Amazon OpenDistro ElasticSearch Security Parent
git-sha1: 7d3518f77f7e614e7bec8523b2c867b34f1b67d6

In a previous iteration of this PR, installed opensearch-security plugin on OpenSearch 1.1.0, and started the cluster.

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

Use the profile to depend on OpenSearch 1.1.0-SNAPSHOT as well.

Is it backport from main branch? (If yes, please add backport PR # and commits #)

No

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vrozov

Building SNAPSHOT must be a separate PR from upgrade to OpenSearch 1.1, especially that there is already open PR #1335.

codecov-commenter · 2021-08-17T20:27:25Z

Codecov Report

Merging #1409 (a0299e6) into main (f66c4bd) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a0299e6 differs from pull request most recent head 4fa717e. Consider uploading reports for the commit 4fa717e to get more accurate results

@@             Coverage Diff              @@
##               main    #1409      +/-   ##
============================================
+ Coverage     64.79%   64.81%   +0.02%     
  Complexity     3214     3214              
============================================
  Files           247      247              
  Lines         17264    17264              
  Branches       3053     3053              
============================================
+ Hits          11186    11190       +4     
+ Misses         4529     4525       -4     
  Partials       1549     1549

Impacted Files	Coverage Δ
...security/configuration/DlsFlsFilterLeafReader.java	`59.76% <0.00%> (-0.71%)`	⬇️
...org/opensearch/security/rest/TenantInfoAction.java	`88.23% <0.00%> (+10.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd47f31...4fa717e. Read the comment docs.

dblock · 2021-08-17T22:04:20Z

I'll be happy to rebase this on top of #1335 when it's merged.

dblock · 2021-08-18T17:18:46Z

There's probably some more that can be done here to make plugin-descriptor.properties auto-populate these versions.

cliu123 · 2021-08-24T20:53:12Z

@dblock With this PR merged, the main branch now support OpenSearch 1.1. Please rebase this branch against main branch.

dblock · 2021-08-24T23:30:28Z

This is ready to review @vrozov @cliu123.

cliu123 · 2021-08-25T05:32:51Z

plugin-descriptor.properties

@@ -3,7 +3,7 @@
 description=Provide access control related features for OpenSearch 1.0.0
 #
 # 'version': plugin's version
-version=1.0.1.0
+version=1.1.0.0


This is security plugin version, not the OpenSearch version. If the goal of this PR is to add -SNAPSHOT suffix in the OpenSearch version, this line doesn't need to be changed.

The plugin version needs to be incremented because we're building OpenSearch 1.1. Every other plugin says it's version 1.1.0.0-SNAPSHOT.

I would expect 1.1.0.0-SNAPSHOT, not 1.1.0.0. If it is not snapshot, version should not be changed.

This properties file by default has a number without snapshot. Then, with a profile, we change it to be -SNAPSHOT unless -Dbuild.snapshot=false. You can't have the logical condition the other way around if you want the default to be -Dbuild.snapshot=false.

cliu123 · 2021-08-25T05:34:55Z

pom.xml

@@ -68,7 +68,8 @@
        <maven.compiler.target>1.8</maven.compiler.target>
        <maven.compiler.release>8</maven.compiler.release>

-        <opensearch.version>1.1.0</opensearch.version>
+        <opensearch.version>1.1.0-SNAPSHOT</opensearch.version>
+        <version>1.1.0.0</version>


This is referenced on the line 37 that is security plugin version. Same as this comment, doesn't seem to need a change at here. If yes, this is the example PR to bump plugin version.

It had to move to properties or you cannot set it via a profile.

cliu123 · 2021-08-25T05:35:16Z

pom.xml

@@ -103,7 +104,6 @@
        <url>https://github.com/opensearch-project/security</url>
        <connection>scm:git:[email protected]:opensearch-project/security.git</connection>
        <developerConnection>scm:git:[email protected]:opensearch-project/security.git</developerConnection>
-        <tag>1.0.1.0</tag>


Why are we removing the tag here?

What is the purpose of it here? I believe it's unused.

<url>, <connection> and <developerConnection> are not used either. It is there mostly for historical reasons. I don't see a good reason to remove <tag> only.

cliu123 · 2021-08-25T05:36:57Z

pom.xml

+                </property>
+            </activation>
+            <properties>
+                <version>1.1.0.0-SNAPSHOT</version>


Looks like this PR is bumping security version from 1.0.1.0 to 1.1.0.0. If that's the case, is that the case?

Yes, this is the case, I updated the description of the PR.

Must be consistent with plugin-descriptor.properties, I don't see how this can be done using profiles.

Update: by default the version comes from plugin.properties and is set to 1.1.0.0. This sets the version to 1.1.0.0-SNAPSHOT unless you specify -Dbuild.snapshot=false. Meaning it sets it by default. This effectively enables building both, snapshot or not snapshot, with snapshot by default.

If you put 1.1.0.0-SNAPSHOT in the properties file, then this profile condition would have to be inverted. But then the default can't be snapshot=true.

cliu123 · 2021-08-26T04:57:42Z

Tested the following cases:

Built security plugin on OpenSearch 1.1.0-SNAPSHOT. The build reproduces opensearch-security-1.1.0.0-SNAPSHOT.zip
Installed opensearch-security plugin on OpenSearch 1.1.0, and started the cluster.
CD run

.github/workflows/cd.yml

.github/workflows/ci.yml

dblock · 2021-08-26T20:37:48Z

Ready to re-review.

vrozov · 2021-08-27T22:08:30Z

.github/workflows/ci.yml

@@ -45,7 +45,7 @@ jobs:

    - name: Build OpenSearch
      working-directory: ./OpenSearch
-      run: ./gradlew publishToMavenLocal -Dbuild.snapshot=false
+      run: ./gradlew publishToMavenLocal


This changes version of OpenSearch and not the security plugin to -SNAPSHOT. It was supposed to be part of #1335. @cliu123 I'd prefer to have a separate PR that changes OpenSearch dependency version to -SNAPSHOT

It does both at build time.

vrozov · 2021-08-27T22:12:17Z

.github/workflows/cd.yml

@@ -35,13 +35,13 @@ jobs:

    - name: Build OpenSearch
      working-directory: ./OpenSearch
-      run: ./gradlew publishToMavenLocal -Dbuild.snapshot=false
+      run: ./gradlew publishToMavenLocal


CD runs for release and should not use SNAPSHOT version of OpenSearch.

vrozov · 2021-08-27T22:13:33Z

.github/workflows/cd.yml


    - name: Build
      run: |
        mvn -B clean package -Padvanced -DskipTests
        artifact_zip=`ls $(pwd)/target/releases/opensearch-security-*.zip | grep -v admin-standalone`
-        ./gradlew build buildDeb buildRpm --no-daemon -ParchivePath=$artifact_zip -Dbuild.snapshot=false
+        ./gradlew build buildDeb buildRpm --no-daemon -ParchivePath=$artifact_zip


CD runs for release and should not produce SNAPSHOT versions of .rpm and .deb packages.

vrozov · 2021-08-28T02:48:00Z

plugin-descriptor.properties

@@ -3,7 +3,7 @@
 description=Provide access control related features for OpenSearch 1.0.0
 #
 # 'version': plugin's version
-version=1.0.1.0
+version=1.1.0.0


I would expect 1.1.0.0-SNAPSHOT, not 1.1.0.0. If it is not snapshot, version should not be changed.

vrozov · 2021-08-28T02:50:33Z

pom.xml

@@ -68,7 +68,8 @@
        <maven.compiler.target>1.8</maven.compiler.target>
        <maven.compiler.release>8</maven.compiler.release>

-        <opensearch.version>1.1.0</opensearch.version>
+        <opensearch.version>1.1.0-SNAPSHOT</opensearch.version>


OpenSearch version change should be part of another PR.

vrozov · 2021-08-28T03:36:19Z

pom.xml

@@ -103,7 +104,6 @@
        <url>https://github.com/opensearch-project/security</url>
        <connection>scm:git:[email protected]:opensearch-project/security.git</connection>
        <developerConnection>scm:git:[email protected]:opensearch-project/security.git</developerConnection>
-        <tag>1.0.1.0</tag>


<url>, <connection> and <developerConnection> are not used either. It is there mostly for historical reasons. I don't see a good reason to remove <tag> only.

vrozov · 2021-08-28T03:37:56Z

pom.xml

+                </property>
+            </activation>
+            <properties>
+                <version>1.1.0.0-SNAPSHOT</version>


Must be consistent with plugin-descriptor.properties, I don't see how this can be done using profiles.

dblock · 2021-08-28T14:38:13Z

@vrozov

We failed at having a scalable mechanism to distribute maven credentials across 15 plugins, so whereas OpenSearch bundle build 1.0 picked up output from security plugin CD, it will not for 1.1. Bundle will build from the top, including opensearch-min and security plugin, from source. Given that, this change ensures that security CD doesn't build an artifact that can be accidentally promoted to a release, i.e. always depend on a snapshot version of OpenSearch and produce a snapshot version of security plugin. The change in profiles does that, defaults to snapshot build unless you explicitly specify -Dbuild.snapshot=false, this is net new.

The plugin built in bundle is version 1.1, not 1.0.1. Unlike in ODFE or 1.0, plugins are now aligning with OpenSearch: when development starts on version X in a branch 'X', the version in that branch is incremented to X.

Given that, what do you need me to change in this PR to get this in?

vrozov · 2021-08-28T16:42:55Z

@dblock

Security plugin CD pipeline does not publish anything to maven, it creates github draft release.
Plugin version matches OpenSearch version in the first 3 digits. The last digit can be independently changed by the plugin.
Changing dependency on OpenSearch from 1.1.0 to 1.1.0-SNAPSHOT is a self contained change similar to how version was changed from 1.0.0 to 1.1.0 in Upgrade OpenSearch version to 1.1.0 #1335. Prerequisite of building OpenSearch locally or in CI/CD introduces lots of confusion and is error prone ([BUG] Plugin does not build #1400).
I don't quite understand how profile can be used to switch between SNAPSHOT and release. That will allow to use any random commit to build release version that is not supposed to be the release version. Additionally, maven profile has no impact on plugin-descriptor.properties, so profile solution is not complete.

dblock · 2021-08-28T17:32:25Z

@dblock

Security plugin CD pipeline does not publish anything to maven, it creates github draft release.

I was trying to explain how we ended up here. The CD pipeline output is not used by anyone other than dev at this point, and thus should be a snapshot build that depends on OpenSearch snapshot.

Plugin version matches OpenSearch version in the first 3 digits. The last digit can be independently changed by the plugin.

Yes.

Changing dependency on OpenSearch from 1.1.0 to 1.1.0-SNAPSHOT is a self contained change similar to how version was changed from 1.0.0 to 1.1.0 in Upgrade OpenSearch version to 1.1.0 #1335. Prerequisite of building OpenSearch locally or in CI/CD introduces lots of confusion and is error prone ([BUG] Plugin does not build #1400).

I am not trying to change dependency from OpenSearch 1.1.0 to 1.1.0-SNAPSHOT. I am trying to make security plugin build against 1.1.0-SNAPSHOT by default, and 1.1.0 if -Dbuild.snapshot=false is specified. I can split these commits if it helps, but it will hide this fact. Just tell me what to do.

The pre-requisite of building OpenSearch locally will go away with opensearch-project/opensearch-build#20.

I don't quite understand how profile can be used to switch between SNAPSHOT and release. That will allow to use any random commit to build release version that is not supposed to be the release version. Additionally, maven profile has no impact on plugin-descriptor.properties, so profile solution is not complete.

A released version is one that is tested as part of the bundle, signed and uploaded to opensearch.org. Every daily build can be a release candidate and is "declared" release by signing and publishing. Are you proposing to manually change 1.1.0-SNAPSHOT to 1.1.0 when "we are ready"? That seems like a ton of busy work.

We have two pipelines:

CI in this repo, needs to build snapshot
Bundle pipeline, needs to build release

Plugins have had -Dbuild.snapshot=true/false forever, except security plugin. How do you propose we accomplish this for the security plugin?

I will deal with plugin-descriptor.properties when we settle simpler questions.

vrozov · 2021-08-29T21:24:37Z

Plugins have had -Dbuild.snapshot=true/false forever, except security plugin. How do you propose we accomplish this for the security plugin?

Other plugins had this option as they utilize OpenSearch gradle extension. Security plugin is not built with gradle, it is built with maven and never supported -Dbuild.snapshot. I still don't see how that can be done in maven due to dependency issue and impact on plugin-descriptor.properties.

vrozov · 2021-08-29T21:56:24Z

I was trying to explain how we ended up here. The CD pipeline output is not used by anyone other than dev at this point, and thus should be a snapshot build that depends on OpenSearch snapshot.

While CD pipeline is no longer used to publish to maven and to S3 to produce distribution bundle, it is used to create release draft on github. There is no usage of CD pipeline outside of release build. For PR and builds on main CI is used.

dblock · 2021-08-30T14:53:46Z

Extracted version increment into #1429.

dblock · 2021-08-30T23:16:09Z

A hacky-er alternative, opensearch-project/opensearch-build#356.

snapshot. Signed-off-by: dblock <[email protected]>

vrozov · 2021-08-31T02:20:01Z

Maven does not support using the same pom.xml to describe artifacts with two different versions (for example 1.1.0.0 and 1.1.0.0-SNAPSHOT). The proposed solution only works to generate .jar and .zip artifacts during the build. AFAIK, such pom.xml with dual versions will be invalid should it be installed into local and/or remote maven repository.

@dblock I would vote for the other solution that you proposed opensearch-project/opensearch-build#356

dblock · 2021-08-31T02:24:23Z

I agree, closing in favor of opensearch-project/opensearch-build#356.

dblock requested a review from a team August 17, 2021 19:16

dblock changed the title ~~Default to building -SNAPSHOT and use OpenSearch 1.1.~~ Default to building -SNAPSHOT, use OpenSearch 1.1. Aug 17, 2021

dblock mentioned this pull request Aug 17, 2021

[BUG] Snapshot build doesn't produce a snapshot build or an artifact named with -SNAPSHOT #1403

Closed

vrozov suggested changes Aug 17, 2021

View reviewed changes

adnapibar mentioned this pull request Aug 18, 2021

Build bundle 1.1-SNAPSHOT opensearch-project/opensearch-build#179

Closed

14 tasks

dblock force-pushed the fix-snapshot-build branch from c7d81c5 to 5b2ad0a Compare August 18, 2021 17:07

dblock force-pushed the fix-snapshot-build branch from 5b2ad0a to 9bf4c0f Compare August 21, 2021 13:08

dblock mentioned this pull request Aug 23, 2021

Fix index permissions for negative lookahead and negated regex index patterns #1300

Merged

dblock force-pushed the fix-snapshot-build branch 4 times, most recently from 06a0fb0 to 25383ef Compare August 24, 2021 21:35

dblock requested review from vrozov and cliu123 August 24, 2021 23:30

cliu123 reviewed Aug 25, 2021

View reviewed changes

dblock changed the title ~~Default to building -SNAPSHOT, use OpenSearch 1.1.~~ Default to building -SNAPSHOT, increment version to 1.1.0.0, and use OpenSearch 1.1. Aug 25, 2021

cliu123 reviewed Aug 26, 2021

View reviewed changes

.github/workflows/cd.yml Outdated Show resolved Hide resolved

cliu123 reviewed Aug 26, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

cliu123 reviewed Aug 26, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

cliu123 previously approved these changes Aug 27, 2021

View reviewed changes

vrozov reviewed Aug 28, 2021

View reviewed changes

dblock dismissed cliu123’s stale review via a0299e6 August 30, 2021 21:45

dblock force-pushed the fix-snapshot-build branch 3 times, most recently from efad3d8 to 371c35a Compare August 30, 2021 21:47

dblock changed the title ~~Default to building -SNAPSHOT, increment version to 1.1.0.0, and use OpenSearch 1.1.~~ Add support for -Dbuild.snapshot=true/false and default to building snapshot. Aug 30, 2021

dblock force-pushed the fix-snapshot-build branch 3 times, most recently from 7d3518f to 4fa717e Compare August 30, 2021 22:10

dblock mentioned this pull request Aug 30, 2021

Patch security plugin version at build time. opensearch-project/opensearch-build#356

Merged

1 task

Add support for -Dbuild.snapshot=true/false and default to building

a247984

snapshot. Signed-off-by: dblock <[email protected]>

dblock force-pushed the fix-snapshot-build branch from 4fa717e to a247984 Compare August 30, 2021 23:19

dblock closed this Aug 31, 2021

Add support for -Dbuild.snapshot=true/false and default to building snapshot. #1409

Add support for -Dbuild.snapshot=true/false and default to building snapshot. #1409

Conversation

dblock commented Aug 17, 2021 • edited Loading

opensearch-security pull request intake form

Snapshot (default)

Not Snapshot

vrozov left a comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 17, 2021 • edited Loading

Codecov Report

dblock commented Aug 17, 2021

dblock commented Aug 18, 2021

cliu123 commented Aug 24, 2021

dblock commented Aug 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cliu123 Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dblock Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cliu123 commented Aug 26, 2021

dblock commented Aug 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dblock commented Aug 28, 2021

vrozov commented Aug 28, 2021

dblock commented Aug 28, 2021 • edited Loading

vrozov commented Aug 29, 2021

vrozov commented Aug 29, 2021

dblock commented Aug 30, 2021

dblock commented Aug 30, 2021

vrozov commented Aug 31, 2021

dblock commented Aug 31, 2021

dblock commented Aug 17, 2021 •

edited

Loading

codecov-commenter commented Aug 17, 2021 •

edited

Loading

cliu123 Aug 25, 2021 •

edited

Loading

dblock Aug 25, 2021 •

edited

Loading

dblock commented Aug 28, 2021 •

edited

Loading