Enhanced the affinity for opensearch-cluster to have a default podAntiAffinity #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshm90
requested review from
idanl21,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
…iAffinity This PR helps to add a default podAntiAffinity rule in each nodePool component with the cluster-name as selector to schedule the replicas on different nodes on Kubernetes. All components using the same rule, thus each replica from nodePool components schedules on different nodes. This can be improved on component wise in nodePool in future if needed. Fixes opensearch-project#285 - [x] Commits are signed per the DCO using --signoff - [x] Unittest added for the new/changed functionality and all unit tests are successful - [x] Customer-visible features documented - [x] No linter warnings (`helm lint` and `helm template`) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Rajesh M <[email protected]>
rajeshm90
force-pushed
the
feature/supports-default-antiaffinity
branch
from
72bbfc4 to
8c84d0f
Compare
Signed-off-by: Rajesh M <[email protected]>
|
hi @prudhvigodithi I remember we discussed that we need to add a pipeline job for helm-doc to test if users didn't forget to update documentation, could you help with this? |
Signed-off-by: Rajesh M <[email protected]>
Signed-off-by: Rajesh M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR helps to add a default podAntiAffinity rule in each nodePool component with the node pool as selector to schedule the replicas on different nodes on Kubernetes.
Issues Resolved
Fixes #285
Check List
helm lintandhelm template)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check
here.
Signed-off-by: Rajesh M [email protected]