Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Reports flakey test fix for 2.5 #1728

Merged
merged 2 commits into from
Feb 21, 2025
Merged

[BUG]Reports flakey test fix for 2.5 #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9669817
Reports falkey test fix
sumukhswamy Feb 21, 2025
c927742
chamged workflow
sumukhswamy Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release-e2e-workflow-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,19 @@ jobs:
command: ${{ inputs.test-command }}
wait-on: 'http://localhost:5601'
# Screenshots are only captured on failure, will change this once we do visual regression tests
- uses: actions/upload-artifact@v1
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
path: cypress-test/cypress/screenshots
# Test run video was always captured, so this action uses "always()" condition
- uses: actions/upload-artifact@v1
- uses: actions/upload-artifact@v4
if: always()
with:
name: cypress-videos
path: cypress-test/cypress/videos
# Test reports was always captured, so this action uses "always()" condition
- uses: actions/upload-artifact@v1
- uses: actions/upload-artifact@v4
if: always()
with:
name: cypress-results
Expand Down
11 changes: 4 additions & 7 deletions cypress/integration/plugins/reports-dashboards/04-download.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ describe('Cypress', () => {
});

it('Download from reporting homepage', () => {
cy.intercept('GET', `${BASE_PATH}/api/reporting/generateReport/*`).as(
'generateReport'
);
cy.visit(`${BASE_PATH}/app/reports-dashboards#/`, {
waitForGetTenant: true,
});
Expand All @@ -40,13 +43,7 @@ describe('Cypress', () => {
cy.get('[id="landingPageOnDemandDownload"]')
.contains('PDF')
.click({ force: true });
cy.get('body').then(($body) => {
if ($body.find('#downloadInProgressLoadingModal').length > 0) {
return;
} else {
assert(false);
}
});
cy.wait('@generateReport').its('response.statusCode').should('eq', 200);
});

it('Download pdf from in-context menu', () => {
Expand Down
Loading