-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps-dashboards] Update data source name and rebase code in maps #1147
[maps-dashboards] Update data source name and rebase code in maps #1147
Conversation
Signed-off-by: Junqiu Lei <[email protected]>
00eb393
to
e313c2f
Compare
All in all, the test passed in my local and looks like failure is due to outdated maps plugin used in the CI. Looked into the CI failure, looks like the maps UI in cypress CI isn't latest from maps-dashboards main branch. The OSD artifact used in CI come from https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch-dashboards/detail/distribution-build-opensearch-dashboards/7499/pipeline/164, I saw build error message for maps-dashboards and have auto cut issue: opensearch-project/dashboards-maps#596
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to post your local test result in the PR.
LGTM and approved, let's wait for a up-to-date build candidate to make the flow pass before merging the code.
BTW, any backport label needed? Is it for 2.13?
Added local test results on PR description. Yes please help add tag |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1147-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 424f59c73b745cca762fa11a43abbc8dc460d562
# Push it to GitHub
git push --set-upstream origin backport/backport-1147-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@junqiu-lei would you mind do manual backport to 2.x? |
…earch-project#1147) Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 424f59c) Signed-off-by: Junqiu Lei <[email protected]>
@Hailong-am The backport PR raised out by #1158 |
#1158) (cherry picked from commit 424f59c) Signed-off-by: Junqiu Lei <[email protected]>
#1158) (cherry picked from commit 424f59c) Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 7d33af6)
#1158) (#1165) (cherry picked from commit 424f59c) Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 7d33af6) Co-authored-by: Junqiu Lei <[email protected]>
Description
This PR does:
Test
Local test:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.