Address PR comments

Signed-off-by: Lin Wang <[email protected]>
opensearch-project · Nov 8, 2024 · cb2a839 · cb2a839
1 parent c45a9c8
commit cb2a839
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/...opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js b/...opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js
@@ -147,21 +147,24 @@ if (Cypress.env('WORKSPACE_ENABLED')) {
       });
     });
 
-    if (Cypress.env('SECURITY_ENABLED')) {
+    if (
+      Cypress.env('SAVED_OBJECTS_PERMISSION_ENABLED') &&
+      Cypress.env('SECURITY_ENABLED')
+    ) {
       describe('update with different workspace access level', () => {
-        let originalUser = ADMIN_AUTH.username;
-        let originalPassword = ADMIN_AUTH.password;
+        const originalUser = ADMIN_AUTH.username;
+        const originalPassword = ADMIN_AUTH.password;
         beforeEach(() => {
-          originalUser = ADMIN_AUTH.username;
-          originalPassword = ADMIN_AUTH.password;
+          ADMIN_AUTH.username = originalUser;
+          ADMIN_AUTH.password = originalPassword;
         });
-        afterEach(() => {
+        after(() => {
           ADMIN_AUTH.newUser = originalUser;
           ADMIN_AUTH.newPassword = originalPassword;
         });
         it('should not able to update workspace meta for non workspace admin', () => {
-          ADMIN_AUTH.newUser = 'kibanaserver';
-          ADMIN_AUTH.newPassword = 'kibanaserver';
+          ADMIN_AUTH.newUser = NONE_DASHBOARDS_ADMIN_USER.username;
+          ADMIN_AUTH.newPassword = NONE_DASHBOARDS_ADMIN_USER.password;
 
           // Visit workspace list page
           miscUtils.visitPage(`/app/workspace_list`);