Allow incremental build to respect version qualifier #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
66 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5327 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 202 202
Lines 7042 7043 +1
=======================================
+ Hits 6482 6483 +1
Misses 560 560 ☔ View full report in Codecov by Sentry. |
zelinh
reviewed
Feb 17, 2025
Signed-off-by: Peter Zhu <[email protected]>
zelinh
approved these changes
Feb 17, 2025
peterzhuamazon
deleted the
update-incremental-build-version-with-qualifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow incremental build to respect version qualifier
Issues Resolved
#3747
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/10821/pipeline/77
Despite the ref is the same every component rebuild due to version mismatch as qualifier field was initially designed to be only exist in input manifest, while build / dist manifest will put it as part of the version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.