Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor releaseTag workflow and add tests #4974

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Refactor releaseTag workflow and add tests #4974

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3049ba2
Fix parameter name for release tag workflow
gaiksaya Aug 27, 2024
f56aa2b
Add tests
gaiksaya Aug 28, 2024
54fc3f7
Fix lint
gaiksaya Aug 28, 2024
1c268c0
refactor
gaiksaya Aug 28, 2024
06fe78b
Fix typo
gaiksaya Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jenkins/release-workflows/release-tag.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ pipeline {
steps {
echo 'Triggering manifest lock workflow'
build job: 'release-manifest-commit-lock', wait: true, parameters: [
string(name: 'RELEASE_VERSION', value: "${params.RELEASE_VERSION}"),
string(name: 'RELEASE_VERSION', value: "${params.VERSION}"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How we lock the manifest to tag in this triggered job? We have a product parameters in this tag creation job but seems like we locked both OS & OSD manifests with tags in one job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in discussion to merge both OS and OSD tag creation into one run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the workflow to accommodate both OS and OSD tag creation. In this way manifest lock would also happen once and for all.
Thanks!

string(name: 'MANIFEST_LOCK_ACTION', value: "UPDATE_TO_TAGS")
]
echo 'Pull Request to lock manifest created successfully!'
Expand Down
Loading