Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aws sdk to version 2.30.18 to mitigate CVE-2025-24970 #3565

Conversation

peterzhuamazon
Copy link
Member

Description

Bump aws sdk to version 2.30.18 to mitigate CVE-2025-24970

Related Issues

opensearch-project/opensearch-build#5323

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon had a problem deploying to ml-commons-cicd-env-require-approval February 19, 2025 21:45 — with GitHub Actions Error
@peterzhuamazon peterzhuamazon deployed to ml-commons-cicd-env-require-approval February 19, 2025 21:45 — with GitHub Actions Active
@peterzhuamazon peterzhuamazon had a problem deploying to ml-commons-cicd-env-require-approval February 19, 2025 21:45 — with GitHub Actions Failure
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env-require-approval February 19, 2025 21:45 — with GitHub Actions Inactive
implementation 'software.amazon.awssdk:apache-client'
implementation ('com.amazonaws:aws-encryption-sdk-java:2.4.1') {
exclude group: 'org.bouncycastle', module: 'bcprov-ext-jdk18on'
}
implementation 'org.bouncycastle:bcprov-jdk18on:1.78.1'

compileOnly group: 'software.amazon.awssdk', name: 'aws-core', version: '2.30.18'
compileOnly group: 'software.amazon.awssdk', name: 's3', version: '2.29.12'
compileOnly group: 'software.amazon.awssdk', name: 'regions', version: '2.29.12'
compileOnly group: 'software.amazon.awssdk', name: 's3', version: '2.30.18'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does core uses awssdk? I was wondering if we could use something like implementation("com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}") so that we don't have to worry about version from plugin level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core did have a pointer here: https://github.com/opensearch-project/OpenSearch/blob/main/gradle/libs.versions.toml#L55

However, netty has its own pointer so they just updated netty directly:
opensearch-project/OpenSearch@c82fffe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update core to the new version first.

@peterzhuamazon
Copy link
Member Author

Close in favor of this PR:

Also pending core upgrade as newer version of aws sdk has more dependencies on core.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants