Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.19] Add interface for no postprocessing function case #3558

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f9aef70 from #3553

* Add interface for no postprocessing function case

Signed-off-by: Sicheng Song <[email protected]>

* Correction after test

Signed-off-by: Sicheng Song <[email protected]>

* Make exception message clearer

Signed-off-by: Sicheng Song <[email protected]>

* Fix typo

Signed-off-by: Sicheng Song <[email protected]>

* Strictly the interface with correct post processing function

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit f9aef70)
@Zhangxunmt Zhangxunmt merged commit 7bb62fc into 2.19 Feb 18, 2025
9 of 14 checks passed
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.19@ffd22e5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...pensearch/ml/common/utils/ModelInterfaceUtils.java 91.66% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             2.19    #3558   +/-   ##
=======================================
  Coverage        ?   80.27%           
  Complexity      ?     6931           
=======================================
  Files           ?      610           
  Lines           ?    30243           
  Branches        ?     3381           
=======================================
  Hits            ?    24279           
  Misses          ?     4506           
  Partials        ?     1458           
Flag Coverage Δ
ml-commons 80.27% <92.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants