Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating bulk update to use sdkclient #3546

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

dhrubo-os
Copy link
Collaborator

Description

[updating bulk update to use sdkclient]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os dhrubo-os force-pushed the multi_tenancy_undeploy branch from 2a03324 to f863d3f Compare February 14, 2025 00:07
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env February 14, 2025 00:09 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env February 14, 2025 00:09 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env February 14, 2025 02:19 — with GitHub Actions Inactive
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 60.78431% with 40 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (d7dec0f) to head (f863d3f).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 61.97% 21 Missing and 6 partials ⚠️
.../action/undeploy/TransportUndeployModelAction.java 58.06% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3546      +/-   ##
============================================
+ Coverage     80.25%   80.26%   +0.01%     
- Complexity     6906     6924      +18     
============================================
  Files           610      610              
  Lines         30077    30236     +159     
  Branches       3368     3376       +8     
============================================
+ Hits          24137    24269     +132     
- Misses         4487     4509      +22     
- Partials       1453     1458       +5     
Flag Coverage Δ
ml-commons 80.26% <60.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 109 to 113
void processUndeployModelResponseAndUpdate(
MLUndeployModelNodesRequest undeployModelNodesRequest,
MLUndeployModelNodesResponse undeployModelNodesResponse,
ActionListener<MLUndeployModelNodesResponse> listener
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only additional tenantId is needed in this function. Pass the tenantId instead of the entire undeployModelNodesRequest? As this function is used for processing the response, so passing an entire request is a little bit confusing for me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense. Addressed.

Signed-off-by: Dhrubo Saha <[email protected]>
@dhrubo-os dhrubo-os merged commit 62ce55b into opensearch-project:main Feb 18, 2025
8 of 10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3546-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62ce55b6791762195898c791b2996b5cc27b0eab
# Push it to GitHub
git push --set-upstream origin backport/backport-3546-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3546-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-3546-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62ce55b6791762195898c791b2996b5cc27b0eab
# Push it to GitHub
git push --set-upstream origin backport/backport-3546-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-3546-to-2.19.

dhrubo-os added a commit to dhrubo-os/ml-commons that referenced this pull request Feb 18, 2025
* updating bulk update to use sdkclient

Signed-off-by: Dhrubo Saha <[email protected]>

* addressed comments

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>
dhrubo-os added a commit that referenced this pull request Feb 18, 2025
* updating bulk update to use sdkclient



* addressed comments



---------

Signed-off-by: Dhrubo Saha <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 18, 2025
* updating bulk update to use sdkclient

* addressed comments

---------

Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit d8670c5)
dhrubo-os added a commit that referenced this pull request Feb 18, 2025
* updating bulk update to use sdkclient

* addressed comments

---------

Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit d8670c5)

Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants