-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating bulk update to use sdkclient #3546
updating bulk update to use sdkclient #3546
Conversation
2a03324
to
f863d3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
============================================
+ Coverage 80.25% 80.26% +0.01%
- Complexity 6906 6924 +18
============================================
Files 610 610
Lines 30077 30236 +159
Branches 3368 3376 +8
============================================
+ Hits 24137 24269 +132
- Misses 4487 4509 +22
- Partials 1453 1458 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dhrubo Saha <[email protected]>
f863d3f
to
0059eab
Compare
void processUndeployModelResponseAndUpdate( | ||
MLUndeployModelNodesRequest undeployModelNodesRequest, | ||
MLUndeployModelNodesResponse undeployModelNodesResponse, | ||
ActionListener<MLUndeployModelNodesResponse> listener | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like only additional tenantId
is needed in this function. Pass the tenantId
instead of the entire undeployModelNodesRequest
? As this function is used for processing the response, so passing an entire request is a little bit confusing for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense. Addressed.
Signed-off-by: Dhrubo Saha <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3546-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62ce55b6791762195898c791b2996b5cc27b0eab
# Push it to GitHub
git push --set-upstream origin backport/backport-3546-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-3546-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62ce55b6791762195898c791b2996b5cc27b0eab
# Push it to GitHub
git push --set-upstream origin backport/backport-3546-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19 Then, create a pull request where the |
* updating bulk update to use sdkclient Signed-off-by: Dhrubo Saha <[email protected]> * addressed comments Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]>
* updating bulk update to use sdkclient * addressed comments --------- Signed-off-by: Dhrubo Saha <[email protected]>
* updating bulk update to use sdkclient * addressed comments --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit d8670c5)
* updating bulk update to use sdkclient * addressed comments --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit d8670c5) Co-authored-by: Dhrubo Saha <[email protected]>
Description
[updating bulk update to use sdkclient]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.