-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lucene 10 upgrade test fixes #3530
Lucene 10 upgrade test fixes #3530
Conversation
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
…ter-lucene-upgrade-to-10
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
@peterzhuamazon can you please help review this PR? This should help with the lucene 10 upgrade and also update the alpha artifacts, thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
============================================
+ Coverage 80.25% 80.27% +0.02%
- Complexity 6906 6908 +2
============================================
Files 610 610
Lines 30077 30081 +4
Branches 3368 3368
============================================
+ Hits 24137 24148 +11
+ Misses 4487 4482 -5
+ Partials 1453 1451 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, seems all required class path updates are included for Lucene 10. From the codecov failure: Can you add a test to cover this updated function call r.getHits().getTotalHits().value();? |
Signed-off-by: rithin-pullela-aws <[email protected]>
@@ -419,6 +419,7 @@ configurations.all { | |||
resolutionStrategy.force "org.apache.logging.log4j:log4j-api:2.24.2" | |||
resolutionStrategy.force "org.apache.logging.log4j:log4j-core:2.24.2" | |||
resolutionStrategy.force "jakarta.json:jakarta.json-api:2.1.3" | |||
resolutionStrategy.force "org.opensearch:opensearch:3.0.0-alpha1-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hardcoding, you should use ${opensearch_version}
.
Jacoco also needs to be |
seems some comments needed to address and those are addressed in #3426
Why are we duplicating the effort? When a PR is already raised from @zane-neo |
We wanted to test the proposed changes and potentially have them merged. Unfortunately, we could not do that. |
@rithin-pullela-aws do we need this PR anymore? |
Closing this since #3426 is successfully merged |
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.