[Navigation] Register all plugins to NavGroups #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
17 tasks
added 2 commits
July 2, 2024 11:54
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
added 2 commits
July 17, 2024 22:50
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
SuZhou-Joe
approved these changes
Jul 18, 2024
Signed-off-by: Adam Tackett <[email protected]>
rupal-bq
approved these changes
Jul 18, 2024
derek-ho
reviewed
Jul 18, 2024
derek-ho
reviewed
Jul 18, 2024
ps48
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add a function to register all plugin Nav groups and categories Signed-off-by: Adam Tackett <[email protected]> * Updated addNavLinkGroups path Signed-off-by: Adam Tackett <[email protected]> * Add always show to analytics group Signed-off-by: Adam Tackett <[email protected]> * Adjust dashboardsAndReport rename and lint errors Signed-off-by: Adam Tackett <[email protected]> * Add groups and remove analytics Signed-off-by: Adam Tackett <[email protected]> * Fix lint error Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit cc1b533) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Jul 19, 2024
* Add a function to register all plugin Nav groups and categories * Updated addNavLinkGroups path * Add always show to analytics group * Adjust dashboardsAndReport rename and lint errors * Add groups and remove analytics * Fix lint error --------- (cherry picked from commit cc1b533) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a function that registers all the plugins to their corresponding NavGroups and NavCategories:
Issues Resolved
opensearch-project/OpenSearch-Dashboards#7029
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.