Fix undefined date error while generating CSV report #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
rupal-bq
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-undefined-date-csv-error #309 +/- ##
================================================================
- Coverage 74.47% 74.44% -0.03%
================================================================
Files 30 30
Lines 1904 1906 +2
Branches 410 413 +3
================================================================
+ Hits 1418 1419 +1
- Misses 483 484 +1
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuali925
approved these changes
Feb 20, 2024
Signed-off-by: Rupal Mahajan <[email protected]>
This reverts commit 9471f30. Signed-off-by: Rupal Mahajan <[email protected]>
will raise separate PR to increase test coverage |
vamsimanohar
approved these changes
Feb 21, 2024
rupal-bq
merged commit 241c6f5
into
opensearch-project:fix-undefined-date-csv-error
9 of 11 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Fix undefined date while generating csv Signed-off-by: Rupal Mahajan <[email protected]> * Add test Signed-off-by: Rupal Mahajan <[email protected]> * Revert "Add test" This reverts commit 9471f30. Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 241c6f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Fix undefined date while generating csv * Add test * Revert "Add test" This reverts commit 9471f30. --------- (cherry picked from commit 241c6f5) Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#308
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.