Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cross-cluster-replication plugin 3.0.0 baseline JDK version to JDK 21 #1474

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aggarwalShivani
Copy link

Description

Set cross-cluster-replication plugin 3.0.0 baseline JDK version to JDK 21

Related Issues

Resolves #1393

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala
Copy link
Member

ankitkala commented Jan 17, 2025

Thanks for taking this up!
Change looks fine to me. Can you look at the failing workflows? I think you need to upgrade JDK for security and knn tests as well: https://github.com/opensearch-project/cross-cluster-replication/blob/main/.github/workflows/security-knn-tests.yml

@aggarwalShivani
Copy link
Author

Thanks for taking this up! Change looks fine to me. Can you look at the failing workflows? I think you need to upgrade JDK for security and knn tests as well: https://github.com/opensearch-project/cross-cluster-replication/blob/main/.github/workflows/security-knn-tests.yml

My bad, I missed pushing this file. I've updated it now, thanks.

@aggarwalShivani
Copy link
Author

Hi @ankitkala
I see some workflows have failed now (example), all with this same error .

/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)

It appears to be unrelated to jdk update, as failures show up even before setup of jdk 21. This could mostly be a compatibility issue with node-version and operating-system perhaps. Not sure how to resolve this 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set cross-cluster-replication plugin 3.0.0 baseline JDK version to JDK-21
2 participants