Make multiple settings dynamic for Merge on Flush #17495
+99
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
bugmakerrrrrr,
jainankitk and
linuxpi
as code owners
github-actions
bot
added
bug
kkewwei
force-pushed
the
dynamic_settings
branch
from
6adb78d to
bbb906f
Compare
|
❌ Gradle check result for bbb906f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
kkewwei
force-pushed
the
dynamic_settings
branch
from
bbb906f to
c8b84a8
Compare
…lush_merge_wait_time`, `index.merge_on_flush.policy`, `index.check_pending_flush.enabled` dynamic Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
kkewwei
force-pushed
the
dynamic_settings
branch
from
c8b84a8 to
b2a9ecc
Compare
|
❕ Gradle check result for b2a9ecc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17495 +/- ##
============================================
+ Coverage 72.42% 72.46% +0.04%
- Complexity 65611 65655 +44
============================================
Files 5304 5306 +2
Lines 304743 304615 -128
Branches 44189 44167 -22
============================================
+ Hits 220701 220736 +35
+ Misses 65888 65836 -52
+ Partials 18154 18043 -111 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
index.merge_on_flush.enabledindex.merge_on_flush.max_full_flush_merge_wait_timeindex.merge_on_flush.policyindex.check_pending_flush.enabled.Related Issues
Resolves #10048
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.