Support sub agg in filter rewrite optimization #17447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Roadmap:Search
|
{"run-benchmark-test": "id_5"} |
|
{"run-benchmark-test": "id_11"} |
bowenlan-amzn
force-pushed
the
sub-agg-pr
branch
from
360b293 to
a031b5a
Compare
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2442/ . Final results will be published once the job is completed. |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2443/ . Final results will be published once the job is completed. |
|
❌ Gradle check result for a031b5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dbwiddis
reviewed
Feb 25, 2025
| collectableSubAggregators, | ||
| sub | ||
| ); | ||
| if (optimized) throw new CollectionTerminatedException(); |
There was a problem hiding this comment.
why create a separate variable here instead of just calling if (filterRewriteOptimizationContext.tryOptimize(...)) { throw... } ?
Comment on lines
+566
to
+570
| // @Override | ||
| // protected boolean tryPrecomputeAggregationForLeaf(LeafReaderContext ctx) throws IOException { | ||
| // finishLeaf(); // May need to wrap up previous leaf if it could not be precomputed | ||
| // return filterRewriteOptimizationContext.tryOptimize(ctx, this::incrementBucketDocCount, segmentMatchAll(context, ctx)); | ||
| // } |
There was a problem hiding this comment.
I assume this will be removed when this is ready for review. :)
Comment on lines
+144
to
+146
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
Why are we catching a checked exception and rethrowing an unchecked exception here when the method is documented to throw IOException?
|
{"run-benchmark-test": "id_4"} |
|
{"run-benchmark-test": "id_4"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2469/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2469/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/39/
|
some really good improvements in range histogram queries and a few keyword terms queries as well. @bowenlan-amzn |
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
force-pushed
the
sub-agg-pr
branch
from
a031b5a to
5a9082d
Compare
|
❌ Gradle check result for 5a9082d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #12602
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.