Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize global ordinal includes/excludes for prefix matching #14371

Merged
merged 7 commits into from
Aug 20, 2024

Address comments from @mch2

1bc728a
Select commit
Loading
Failed to load commit list.
Merged

Optimize global ordinal includes/excludes for prefix matching #14371

Address comments from @mch2
1bc728a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 0s

72.24% (target 70.00%)

View this Pull Request on Codecov

72.24% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 77.88462% with 23 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (093c060) to head (1bc728a).
Report is 6 commits behind head on main.

Files Patch % Lines
...arch/aggregations/bucket/terms/IncludeExclude.java 77.88% 8 Missing and 15 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14371      +/-   ##
============================================
+ Coverage     71.95%   72.24%   +0.29%     
- Complexity    63179    63497     +318     
============================================
  Files          5212     5212              
  Lines        295649   295753     +104     
  Branches      42692    42721      +29     
============================================
+ Hits         212726   213674     +948     
+ Misses        65485    64894     -591     
+ Partials      17438    17185     -253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.