Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/data importer #9408

Merged
merged 8 commits into from
Feb 25, 2025
+467 −159
Merged

Feature/data importer #9408

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
501ce52
move header to top and define sectiobna nd add preview table
ruchidh Feb 6, 2025
b62e78d
add preview load
ruchidh Feb 6, 2025
22a3644
fix ui and add preview table
ruchidh Feb 18, 2025
2fd4543
add data source, indices and mismtach in table
ruchidh Feb 24, 2025
86d92c6
revert changes from yml
ruchidh Feb 25, 2025
445156e
comment data import flag
ruchidh Feb 25, 2025
44db71a
fix line
ruchidh Feb 25, 2025
77bd9b0
revert validate check and give rows count as constant
ruchidh Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions config/opensearch_dashboards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,7 @@
# dynamic_config_service.enabled: false

# Set the value to true to enable direct data import from a file
# data_importer.enabled: false

data_importer.enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd recommend not source controlling this config file. historically, people have created PRs with passwords or IPs that they had to clean up later.

You can add a new package.json script or you can start OSD like

yarn start --data_importer.enabled=true --opensearch_security.enabled=false

Copy link
Member

@huyaboo huyaboo Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I usually use git skip to locally ignore config file changes. But TIL you can add configs on the fly

# Set the backend roles in groups or users, whoever has the backend roles or exactly match the user ids defined in this config will be regard as dashboard admin.
# Dashboard admin will have the access to all the workspaces(workspace.enabled: true) and objects inside OpenSearch Dashboards.
# The default config is [], and no one will be dashboard admin.
Expand Down
Loading