Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTID-64] Add cypress test for auto query updates when switch dataset #9322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TESTID-64] Add cypress test for auto query updates when switch dataset #9322

wants to merge 1 commit into from
+560 −108

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 3, 2025 •
edited
Loading

Description

Switch dataset in discover should automatically update query

Issues Resolved

#8974

Screenshot

NA

Changelog

-test: [TESTID-64] Add cypress test for auto query updates when switch dataset

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Feb 3, 2025
opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 3, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9322 created/updated
9c0f70e
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.70%. Comparing base (527c1dc) to head (694dd51).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9322      +/-   ##
==========================================
- Coverage   61.71%   61.70%   -0.01%     
==========================================
  Files        3816     3816              
  Lines       91829    91829              
  Branches    14543    14543              
==========================================
- Hits        56668    56666       -2     
- Misses      31506    31507       +1     
- Partials     3655     3656       +1
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.18% <ø> (-0.01%) ⬇️
Linux_4 28.90% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.18% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added the v2.20.0 label Feb 3, 2025
opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 3, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9322 created/updated
5b3cdf7
opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 4, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9322 created/updated
34e0342
angle943
angle943 reviewed Feb 4, 2025
View reviewed changes
...nsearch_dashboards/opensearch_dashboards/apps/query_enhancements/autocomplete_switch.spec.js
} from '../../../../../utils/apps/query_enhancements/autocomplete';

const workspaceName = getRandomizedWorkspaceName();
const datasourceName = getRandomizedDatasourceName();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi i am removing the function getRandomizedDatasourceName() in my other open PR: #9319

but if your PR gets merged first, I will take care of it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks for the remind

angle943
angle943 approved these changes Feb 4, 2025
View reviewed changes
...nsearch_dashboards/opensearch_dashboards/apps/query_enhancements/autocomplete_switch.spec.js
describe('discover autocomplete tests', () => {
beforeEach(() => {
cy.setupTestData(
SECONDARY_ENGINE.url,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi I am changing this to PATHS.SECONDARY_ENGINE_URL or something like that in my other PR: #9319

but if your PR gets merged first, i will take care of it (Sorry for redundant comments, just moreso leaving a note to myself)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LDrago27
LDrago27 previously approved these changes Feb 4, 2025
View reviewed changes
opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 4, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9322 created/updated
217b132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angle943 angle943 angle943 approved these changes

@LDrago27 LDrago27 LDrago27 left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative v2.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @angle943 @LDrago27