TESTID-43: add max recent queries tests #9307
Conversation
silvaf-dev
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "test". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9307 +/- ##
==========================================
- Coverage 61.71% 61.70% -0.01%
==========================================
Files 3816 3816
Lines 91829 91829
Branches 14543 14543
==========================================
- Hits 56668 56666 -2
- Misses 31506 31507 +1
- Partials 3655 3656 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "test". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
the
Skip-Changelog
...ensearch_dashboards/opensearch_dashboards/apps/query_enhancements/max_recent_queries.spec.js
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| generateAllTestConfigurations(generateMaxRecentQueriesTestConfiguration).forEach((config) => { | ||
| if (config.language !== 'PPL' && config.language !== 'OpenSearch SQL') return; |
There was a problem hiding this comment.
Could you please leave a comment with why this is the case?
There was a problem hiding this comment.
I suggest not directly use generateAllTestConfigurations and avoid using if in the permutation. Can we define a permutation just for recent query?
One reference is https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9322/files
For autocomplete, sometimes it only test DQL/SQL as well.
There was a problem hiding this comment.
okay I saw you defined generateMaxRecentQueriesTestConfiguration why not use that?
...ensearch_dashboards/opensearch_dashboards/apps/query_enhancements/max_recent_queries.spec.js
Outdated
Show resolved
Hide resolved
...ensearch_dashboards/opensearch_dashboards/apps/query_enhancements/max_recent_queries.spec.js
Outdated
Show resolved
Hide resolved
ananzh
added
discover_2.0-test
|
why skip changelog? |
|
also need to update package.json, you can check other test prs |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "test". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
failed changeset
and removed
Skip-Changelog
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Description
This PR covers all the tests included in TESTID-43 and TESTID-42.
Issues Resolved
Screenshot
Screen.Recording.2025-01-30.at.1_compressed_compressed.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration