[Discover] support description in data-structures #9296
Conversation
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
huyaboo
as code owners
github-actions
bot
added
all-star-contributor
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9296 +/- ##
==========================================
- Coverage 61.71% 61.70% -0.02%
==========================================
Files 3816 3816
Lines 91822 91831 +9
Branches 14542 14544 +2
==========================================
- Hits 56672 56668 -4
- Misses 31495 31507 +12
- Partials 3655 3656 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| {title} | ||
| </EuiText> | ||
| {item.description && ( | ||
| <EuiText size="s" color="subdued" className="datasetTable__itemDescription"> |
There was a problem hiding this comment.
should the title and description have the same size? can imagine if each structure has a description it can get lengthy
There was a problem hiding this comment.
they are the same size?
i can use extra small if it's what you mean. currently there's no way for user to set description, it needs the dataset type config to define what description is
There was a problem hiding this comment.
title and description are both small size text <EuiText size="s", maybe use xs for description?
There was a problem hiding this comment.
makes sense, added truncation
| </EuiText> | ||
| {item.description && ( | ||
| <EuiText size="s" color="subdued" className="datasetTable__itemDescription"> | ||
| {item.description} |
There was a problem hiding this comment.
May be add ellipsis and truncation to support longer descriptions? or it is that dataset type config would have this logic?
There was a problem hiding this comment.
added #9296 (comment)
There was a problem hiding this comment.
Instead of adding custom css, could the utility css class from oui work? .oui-textTruncate
There was a problem hiding this comment.
Signed-off-by: Joshua Li <[email protected]>
joshuali925
force-pushed
the
dataset-description
branch
from
188df54 to
f601b5d
Compare
Description
Sometimes a data structure contains other metadata, it would be helpful to display them as descriptions to the user. Examples can be user defined descriptions, tags, or associated resources.
This PR adds a optional description field for data structures, and it is displayed in the dataset table. Currently it does not add it to dataset selector but can be done in the future.
Issues Resolved
Screenshot
Testing the changes
unit tests added
Changelog
Check List
yarn test:jestyarn test:jest_integration