-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTID-125,126,127,128,129] Saved Query Test Scope Add Todo for Workaround #9287
Conversation
Signed-off-by: Argus Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9287 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 3816 3816
Lines 91694 91694
Branches 14516 14516
=======================================
Hits 56559 56559
Misses 31510 31510
Partials 3625 3625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9287-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a0ad734a88c4a832d525302b072fef41d89122f
# Push it to GitHub
git push --set-upstream origin backport/backport-9287-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Signed-off-by: Argus Li <[email protected]> (cherry picked from commit 5a0ad73)
Signed-off-by: Argus Li <[email protected]> (cherry picked from commit 5a0ad73) Co-authored-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]> Signed-off-by: Ubuntu <[email protected]>
Description
Add Todo Comment for workaround that was added to avoid rarely occurring issue.
The issue is that the Date Picker is expected to be visible when DQL is selected, however it doesn't appear. To workaround this issue, we have to reselect the data source then the query language. This leads to the Date Picker appearing.
Relates to #9229.
Screenshot
Testing the changes
With OSD running, run yarn run cypress open. In E2E specs, you will see 1 new test spec1 saved_queries.spec.js. Run that spec.
Changelog