Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests for Simple dataset Selector #9255

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add Tests for Simple dataset Selector #9255

merged 2 commits into from
Jan 29, 2025
+239 −9

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Jan 22, 2025 •
edited
Loading

Description

Add Tests for Simple Dataset Selector
Split Ci group 10 into 2 parts CI group 10 and CI group 12 to reduce the time taken by the combined Ci group 10 to run.

Issues Resolved

Screenshot

image

Testing the changes

Changelog

  • feat: Add Tests for Simple Dataset Selector

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jan 22, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9255 created/updated
a9f992d
@LDrago27 LDrago27 added discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative backport 2.x labels Jan 22, 2025
@LDrago27 LDrago27 linked an issue Jan 22, 2025 that may be closed by this pull request
[Data Selector and Time Ranges Testing] TESTID-117: Test simple dataset selector #8940
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (dc8865a) to head (9a9d57f).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9255      +/-   ##
==========================================
+ Coverage   61.65%   61.71%   +0.06%     
==========================================
  Files        3816     3816              
  Lines       91694    91822     +128     
  Branches    14516    14542      +26     
==========================================
+ Hits        56535    56672     +137     
+ Misses      31579    31495      -84     
- Partials     3580     3655      +75
Flag Coverage Δ
Linux_1 28.99% <ø> (-0.06%) ⬇️
Linux_2 56.46% <ø> (?)
Linux_3 39.17% <ø> (+0.08%) ⬆️
Linux_4 28.91% <ø> (-0.07%) ⬇️
Windows_1 29.02% <ø> (-0.04%) ⬇️
Windows_2 56.41% <ø> (ø)
Windows_3 39.18% <ø> (+0.09%) ⬆️
Windows_4 28.91% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 force-pushed the simpleDatasetSelector branch 3 times, most recently from 3fd4b98 to 6a899b2 Compare January 23, 2025 21:56
@LDrago27 LDrago27 force-pushed the simpleDatasetSelector branch 2 times, most recently from 18f860a to 9f0014f Compare January 28, 2025 01:03
@ananzh ananzh added the v2.19.0 label Jan 28, 2025
@LDrago27 LDrago27 force-pushed the simpleDatasetSelector branch 6 times, most recently from 3f18e4a to e08a828 Compare January 28, 2025 21:41
@LDrago27 LDrago27 force-pushed the simpleDatasetSelector branch from e08a828 to dd1442f Compare January 28, 2025 22:43
@ananzh ananzh merged commit 6c83d4e into opensearch-project:main Jan 29, 2025
70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 29, 2025
@github-actions @opensearch-changeset-bot
Add Tests for Simple dataset Selector (#9255)
6783c7c 
* Add simple dataset selector tests

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #9255 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6c83d4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 29, 2025
Open
ruchidh pushed a commit to ruchidh/OpenSearch-Dashboards that referenced this pull request Jan 30, 2025
@LDrago27 @opensearch-changeset-bot
Add Tests for Simple dataset Selector (opensearch-project#9255)
978a98d 
* Add simple dataset selector tests

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR opensearch-project#9255 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Ubuntu <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2025
@github-actions @opensearch-changeset-bot
Add Tests for Simple dataset Selector (#9255)
87d74ae 
* Add simple dataset selector tests

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #9255 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6c83d4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@sejli sejli sejli approved these changes

@angle943 angle943 angle943 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x backport 2.19 discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Selector and Time Ranges Testing] TESTID-117: Test simple dataset selector
4 participants
@LDrago27 @angle943 @sejli @ananzh