Custom branding v2

[Ironem]

Signed-off-by: Jiawei YANG [email protected]

Description

Add the feature describe in the feature request #1250.

Issues Resolved

#1250 Custom branding v2

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[tmarkley]

Hey @Ironem thanks for the PR! Can we continue the discussion about this approach over in #1250? I think there are still a couple things we need to ahem iron out.

[joshuarrrr]

Hi @Ironem - thanks again for opening this PR. As discussed in #2044 (comment) and #1250 (comment), the maintainer team would like to avoid introducing any further configuration settings, because each one becomes a backwards compatibility maintenance issue.

Particularly for customizing strings, our preferred approach is to use the i18n plugin which already provides tooling for customizing or overriding any default strings. If there are strings that are not correctly configured for the plugin, feel free to raise issues or PRs to add the i18n wrappers.

Sorry for the delay and uncertainty, we just want to make sure we don't commit to features we can't support long-term.