-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RESPONSIBILITIES.md #194
Conversation
Add code merge responsibility. Signed-off-by: Sandesh Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The TOC update is a must have. Consider the rest.
Signed-off-by: Sandesh Kumar <[email protected]>
Thanks @dblock for the review & suggestions. I have incorporated them in my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for contributing this.
Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Thanks @andrross for the review. Iterated the guidelines with your comments. Let me know if the revised guidelines are more meaningful now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @sandeshkr419 lgtm
Add code merge responsibilities for maintainers.
Description
opensearch-project/OpenSearch#851
Pulling in code merge best practices from opensearch-project/security#2134
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.