Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHTC_PELICANPLATFORM_ORIGIN, which will serve the /pelicanplatform namespace in OSDF #4492

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Add CHTC_PELICANPLATFORM_ORIGIN, which will serve the /pelicanplatform namespace in OSDF #4492

merged 3 commits into from
Jan 21, 2025

Conversation

matyasselmeci
Copy link
Collaborator

No description provided.

brianhlin
brianhlin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the AllowedVOs seems unnecessary

@matyasselmeci
Copy link
Collaborator Author

I think the attribute is necessary (that is, Topology will complain if it's missing), but we shouldn't be restricting it to GLOW.

@matyasselmeci matyasselmeci merged commit 35f4a74 into opensciencegrid:master Jan 21, 2025
4 checks passed
@matyasselmeci matyasselmeci deleted the pr/chtc_pelicanplatform_origin branch January 21, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhlin brianhlin brianhlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matyasselmeci @brianhlin