Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include diff in exception in Result #4997

Merged
merged 3 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions rewrite-core/src/main/java/org/openrewrite/Result.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,9 @@ public Result(@Nullable SourceFile before, @Nullable SourceFile after, Collectio
public Result(@Nullable SourceFile before, SourceFile after) {
this(before, after, after.getMarkers()
.findFirst(RecipesThatMadeChanges.class)
.orElseThrow(() -> new IllegalStateException(
String.format(
"Source file changed but no recipe " +
"reported making a change. %s",
explainWhatChanged(before, after)
)
.orElseThrow(() -> new UnknownSourceFileChangeException(
after,
explainWhatChanged(before, after)
))
.getRecipes());
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/*
* Copyright 2025 the original author or authors.
* <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* https://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite;

import lombok.EqualsAndHashCode;
import lombok.Value;

@Value
@EqualsAndHashCode(callSuper = false)
public class UnknownSourceFileChangeException extends RecipeException {
SourceFile sourceFile;
String diff;

@Override
public String getMessage() {
return "Source file changed but no recipe " +
"reported making a change.";
}
}
Loading